* [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message
@ 2019-06-02 16:00 Emanuel Bennici
2019-06-02 16:16 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Emanuel Bennici @ 2019-06-02 16:00 UTC (permalink / raw)
To: linux-kernel
Cc: Bjorn Helgaas, Joe Perches, Andy Shevchenko, Lukas Wunner,
Rafael J. Wysocki, Tyrel Datwyler, Arnd Bergmann
Add a Whitespace between '-' and 'Exit' to keep the log messages consistent
Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
---
drivers/pci/hotplug/ibmphp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
index 59840a094973..cd73bea12bc7 100644
--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -890,7 +890,7 @@ static int set_bus(struct slot *slot_cur)
/* This is for x440, once Brandon fixes the firmware,
will not need this delay */
msleep(1000);
- debug("%s -Exit\n", __func__);
+ debug("%s - Exit\n", __func__);
return 0;
}
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message
2019-06-02 16:00 [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message Emanuel Bennici
@ 2019-06-02 16:16 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2019-06-02 16:16 UTC (permalink / raw)
To: benniciemanuel78, linux-kernel
Cc: Bjorn Helgaas, Andy Shevchenko, Lukas Wunner, Rafael J. Wysocki,
Tyrel Datwyler, Arnd Bergmann
On Sun, 2019-06-02 at 18:00 +0200, Emanuel Bennici wrote:
> Add a Whitespace between '-' and 'Exit' to keep the log messages consistent
[]
> diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
[]
> @@ -890,7 +890,7 @@ static int set_bus(struct slot *slot_cur)
> /* This is for x440, once Brandon fixes the firmware,
> will not need this delay */
> msleep(1000);
> - debug("%s -Exit\n", __func__);
> + debug("%s - Exit\n", __func__);
These sorts of messages should just be deleted
and the function tracer (ftrace) used instead.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-02 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-02 16:00 [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message Emanuel Bennici
2019-06-02 16:16 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®