mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miroslav Benes <mbenes@suse.cz>
To: jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com
Cc: joe.lawrence@redhat.com, kamalesh@linux.vnet.ibm.com,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	Miroslav Benes <mbenes@suse.cz>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH v4 1/3] stacktrace: Remove weak version of save_stack_trace_tsk_reliable()
Date: Tue, 11 Jun 2019 16:13:18 +0200	[thread overview]
Message-ID: <20190611141320.25359-2-mbenes@suse.cz> (raw)
In-Reply-To: <20190611141320.25359-1-mbenes@suse.cz>

Recent rework of stack trace infrastructure introduced a new set of
helpers for common stack trace operations (commit e9b98e162aa5
("stacktrace: Provide helpers for common stack trace operations") and
related). As a result, save_stack_trace_tsk_reliable() is not directly
called anywhere. Livepatch, currently the only user of the reliable
stack trace feature, now calls stack_trace_save_tsk_reliable().

When CONFIG_HAVE_RELIABLE_STACKTRACE is set and depending on
CONFIG_ARCH_STACKWALK, stack_trace_save_tsk_reliable() calls either
arch_stack_walk_reliable() or mentioned save_stack_trace_tsk_reliable().
x86_64 defines the former, ppc64le the latter. All other architectures
do not have HAVE_RELIABLE_STACKTRACE and include/linux/stacktrace.h
defines -ENOSYS returning version for them.

In short, stack_trace_save_tsk_reliable() returning -ENOSYS defined in
include/linux/stacktrace.h serves the same purpose as the old weak
version of save_stack_trace_tsk_reliable() which is therefore no longer
needed.

Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Miroslav Benes <mbenes@suse.cz>
---
 kernel/stacktrace.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
index 36139de0a3c4..0c3f00db9069 100644
--- a/kernel/stacktrace.c
+++ b/kernel/stacktrace.c
@@ -255,14 +255,6 @@ save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
 	WARN_ONCE(1, KERN_INFO "save_stack_trace_regs() not implemented yet.\n");
 }
 
-__weak int
-save_stack_trace_tsk_reliable(struct task_struct *tsk,
-			      struct stack_trace *trace)
-{
-	WARN_ONCE(1, KERN_INFO "save_stack_tsk_reliable() not implemented yet.\n");
-	return -ENOSYS;
-}
-
 /**
  * stack_trace_save - Save a stack trace into a storage array
  * @store:	Pointer to storage array
-- 
2.21.0


  reply	other threads:[~2019-06-11 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 14:13 [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings Miroslav Benes
2019-06-11 14:13 ` Miroslav Benes [this message]
2019-06-12  8:12   ` [PATCH v4 1/3] stacktrace: Remove weak version of save_stack_trace_tsk_reliable() Petr Mladek
2019-06-12 13:41   ` Kamalesh Babulal
2019-06-16  8:44   ` Thomas Gleixner
2019-06-17 11:16     ` Petr Mladek
2019-06-17 11:58       ` Thomas Gleixner
2019-06-11 14:13 ` [PATCH v4 2/3] Revert "livepatch: Remove reliable stacktrace check in klp_try_switch_task()" Miroslav Benes
2019-06-12  8:15   ` Petr Mladek
2019-06-12 13:41   ` Kamalesh Babulal
2019-06-11 14:13 ` [PATCH v4 3/3] livepatch: Remove duplicate warning about missing reliable stacktrace support Miroslav Benes
2019-06-12 13:52   ` Kamalesh Babulal
2019-06-15 20:43 ` [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings Josh Poimboeuf
2019-06-20 14:30   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611141320.25359-2-mbenes@suse.cz \
    --to=mbenes@suse.cz \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®