mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miroslav Benes <mbenes@suse.cz>
To: jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com
Cc: joe.lawrence@redhat.com, kamalesh@linux.vnet.ibm.com,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	Miroslav Benes <mbenes@suse.cz>
Subject: [PATCH v4 3/3] livepatch: Remove duplicate warning about missing reliable stacktrace support
Date: Tue, 11 Jun 2019 16:13:20 +0200	[thread overview]
Message-ID: <20190611141320.25359-4-mbenes@suse.cz> (raw)
In-Reply-To: <20190611141320.25359-1-mbenes@suse.cz>

From: Petr Mladek <pmladek@suse.com>

WARN_ON_ONCE() could not be called safely under rq lock because
of console deadlock issues. Moreover WARN_ON_ONCE() is superfluous in
klp_check_stack(), because stack_trace_save_tsk_reliable() cannot return
-ENOSYS thanks to klp_have_reliable_stack() check in
klp_try_switch_task().

Signed-off-by: Petr Mladek <pmladek@suse.com>
[ mbenes: changelog edited ]
Signed-off-by: Miroslav Benes <mbenes@suse.cz>
---
 kernel/livepatch/transition.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c
index 7e7ef04689d1..cdf318d86dd6 100644
--- a/kernel/livepatch/transition.c
+++ b/kernel/livepatch/transition.c
@@ -247,7 +247,6 @@ static int klp_check_stack(struct task_struct *task, char *err_buf)
 	int ret, nr_entries;
 
 	ret = stack_trace_save_tsk_reliable(task, entries, ARRAY_SIZE(entries));
-	WARN_ON_ONCE(ret == -ENOSYS);
 	if (ret < 0) {
 		snprintf(err_buf, STACK_ERR_BUF_SIZE,
 			 "%s: %s:%d has an unreliable stack\n",
-- 
2.21.0


  parent reply	other threads:[~2019-06-11 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 14:13 [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings Miroslav Benes
2019-06-11 14:13 ` [PATCH v4 1/3] stacktrace: Remove weak version of save_stack_trace_tsk_reliable() Miroslav Benes
2019-06-12  8:12   ` Petr Mladek
2019-06-12 13:41   ` Kamalesh Babulal
2019-06-16  8:44   ` Thomas Gleixner
2019-06-17 11:16     ` Petr Mladek
2019-06-17 11:58       ` Thomas Gleixner
2019-06-11 14:13 ` [PATCH v4 2/3] Revert "livepatch: Remove reliable stacktrace check in klp_try_switch_task()" Miroslav Benes
2019-06-12  8:15   ` Petr Mladek
2019-06-12 13:41   ` Kamalesh Babulal
2019-06-11 14:13 ` Miroslav Benes [this message]
2019-06-12 13:52   ` [PATCH v4 3/3] livepatch: Remove duplicate warning about missing reliable stacktrace support Kamalesh Babulal
2019-06-15 20:43 ` [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings Josh Poimboeuf
2019-06-20 14:30   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611141320.25359-4-mbenes@suse.cz \
    --to=mbenes@suse.cz \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®