From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: jikos@kernel.org, pmladek@suse.com, joe.lawrence@redhat.com,
kamalesh@linux.vnet.ibm.com, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings
Date: Sat, 15 Jun 2019 15:43:20 -0500 [thread overview]
Message-ID: <20190615204320.i4qxbk2m3ee73vyg@treble> (raw)
In-Reply-To: <20190611141320.25359-1-mbenes@suse.cz>
On Tue, Jun 11, 2019 at 04:13:17PM +0200, Miroslav Benes wrote:
> This is the fourth attempt to improve the situation of reliable stack
> trace warnings in livepatch. Based on discussion in
> 20190531074147.27616-1-pmladek@suse.com (v3).
>
> Changes against v3:
> + weak save_stack_trace_tsk_reliable() removed, because it is not needed
> anymore thanks to Thomas' recent improvements
> + klp_have_reliable_stack() check reintroduced in klp_try_switch_task()
>
> Changes against v2:
>
> + Put back the patch removing WARN_ONCE in the weak
> save_stack_trace_tsk_reliable(). It is related.
> + Simplified patch removing the duplicate warning from klp_check_stack()
> + Update commit message for 3rd patch [Josh]
>
> Miroslav Benes (2):
> stacktrace: Remove weak version of save_stack_trace_tsk_reliable()
> Revert "livepatch: Remove reliable stacktrace check in
> klp_try_switch_task()"
>
> Petr Mladek (1):
> livepatch: Remove duplicate warning about missing reliable stacktrace
> support
>
> kernel/livepatch/transition.c | 8 +++++++-
> kernel/stacktrace.c | 8 --------
> 2 files changed, 7 insertions(+), 9 deletions(-)
Thanks Miroslav for wrapping this up, and thanks to Petr for his
previous work on this.
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
next prev parent reply other threads:[~2019-06-15 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 14:13 Miroslav Benes
2019-06-11 14:13 ` [PATCH v4 1/3] stacktrace: Remove weak version of save_stack_trace_tsk_reliable() Miroslav Benes
2019-06-12 8:12 ` Petr Mladek
2019-06-12 13:41 ` Kamalesh Babulal
2019-06-16 8:44 ` Thomas Gleixner
2019-06-17 11:16 ` Petr Mladek
2019-06-17 11:58 ` Thomas Gleixner
2019-06-11 14:13 ` [PATCH v4 2/3] Revert "livepatch: Remove reliable stacktrace check in klp_try_switch_task()" Miroslav Benes
2019-06-12 8:15 ` Petr Mladek
2019-06-12 13:41 ` Kamalesh Babulal
2019-06-11 14:13 ` [PATCH v4 3/3] livepatch: Remove duplicate warning about missing reliable stacktrace support Miroslav Benes
2019-06-12 13:52 ` Kamalesh Babulal
2019-06-15 20:43 ` Josh Poimboeuf [this message]
2019-06-20 14:30 ` [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615204320.i4qxbk2m3ee73vyg@treble \
--to=jpoimboe@redhat.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®