[chrome-platform-linux:for-next 14/16] drivers/platform/chrome/cros_ec_debugfs.c:288:30: sparse: sparse: symbol 'cros_ec_uptime_fops' was not declared. Should it be static?

[chrome-platform-linux:for-next 14/16] drivers/platform/chrome/cros_ec_debugfs.c:288:30: sparse: sparse: symbol 'cros_ec_uptime_fops' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
head:   3185b85f64fcb5bf521a4093b13ad901569d09c7
commit: 909447f683b31d27b8d59838f8723d744f9300a2 [14/16] platform/chrome: cros_ec_debugfs: Add debugfs entry to retrieve EC uptime
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
        git checkout 909447f683b31d27b8d59838f8723d744f9300a2
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)


Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH chrome-platform-linux] platform/chrome: cros_ec_debugfs: cros_ec_uptime_fops can be static

[kbuild test robot]

Fixes: 909447f683b3 ("platform/chrome: cros_ec_debugfs: Add debugfs entry to retrieve EC uptime")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 cros_ec_debugfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
index 970ba13d..d40902e 100644
--- a/drivers/platform/chrome/cros_ec_debugfs.c
+++ b/drivers/platform/chrome/cros_ec_debugfs.c
@@ -285,7 +285,7 @@ static const struct file_operations cros_ec_pdinfo_fops = {
 	.llseek = default_llseek,
 };
 
-const struct file_operations cros_ec_uptime_fops = {
+static const struct file_operations cros_ec_uptime_fops = {
 	.owner = THIS_MODULE,
 	.open = simple_open,
 	.read = cros_ec_uptime_read,

Re: [RFC PATCH chrome-platform-linux] platform/chrome: cros_ec_debugfs: cros_ec_uptime_fops can be static

[Enric Balletbo i Serra]

On 15/6/19 12:55, kbuild test robot wrote:
> 
> Fixes: 909447f683b3 ("platform/chrome: cros_ec_debugfs: Add debugfs entry to retrieve EC uptime")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  cros_ec_debugfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index 970ba13d..d40902e 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -285,7 +285,7 @@ static const struct file_operations cros_ec_pdinfo_fops = {
>  	.llseek = default_llseek,
>  };
>  
> -const struct file_operations cros_ec_uptime_fops = {
> +static const struct file_operations cros_ec_uptime_fops = {
>  	.owner = THIS_MODULE,
>  	.open = simple_open,
>  	.read = cros_ec_uptime_read,
> 

applied for chrome-platform-5.3