* [PATCH] tracing: remove redundant assignment to pointer 'event'
@ 2019-06-17 12:37 Colin King
2019-06-17 13:42 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2019-06-17 12:37 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The value assigned to pointer 'event' is never read and hence it
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/trace/trace_events_hist.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index ca6b0dff60c5..0013b43d8b4d 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -1294,7 +1294,6 @@ static int __create_synth_event(int argc, const char *name, const char **argv)
event = alloc_synth_event(name, n_fields, fields);
if (IS_ERR(event)) {
ret = PTR_ERR(event);
- event = NULL;
goto err;
}
ret = register_synth_event(event);
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tracing: remove redundant assignment to pointer 'event'
2019-06-17 12:37 [PATCH] tracing: remove redundant assignment to pointer 'event' Colin King
@ 2019-06-17 13:42 ` Steven Rostedt
2019-06-17 13:43 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2019-06-17 13:42 UTC (permalink / raw)
To: Colin King; +Cc: Ingo Molnar, kernel-janitors, linux-kernel
On Mon, 17 Jun 2019 13:37:22 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The value assigned to pointer 'event' is never read and hence it
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> kernel/trace/trace_events_hist.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index ca6b0dff60c5..0013b43d8b4d 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -1294,7 +1294,6 @@ static int __create_synth_event(int argc, const char *name, const char **argv)
> event = alloc_synth_event(name, n_fields, fields);
> if (IS_ERR(event)) {
> ret = PTR_ERR(event);
> - event = NULL;
This is one of those cases where I rather not touch it.
Yeah, it may not be read, but assigning event to NULL isn't dangerous
here. And if we change the code to expect event to be NULL or something
real, it is better to keep this.
-- Steve
> goto err;
> }
> ret = register_synth_event(event);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tracing: remove redundant assignment to pointer 'event'
2019-06-17 13:42 ` Steven Rostedt
@ 2019-06-17 13:43 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2019-06-17 13:43 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Ingo Molnar, kernel-janitors, linux-kernel
On 17/06/2019 14:42, Steven Rostedt wrote:
> On Mon, 17 Jun 2019 13:37:22 +0100
> Colin King <colin.king@canonical.com> wrote:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The value assigned to pointer 'event' is never read and hence it
>> is redundant and can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> kernel/trace/trace_events_hist.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
>> index ca6b0dff60c5..0013b43d8b4d 100644
>> --- a/kernel/trace/trace_events_hist.c
>> +++ b/kernel/trace/trace_events_hist.c
>> @@ -1294,7 +1294,6 @@ static int __create_synth_event(int argc, const char *name, const char **argv)
>> event = alloc_synth_event(name, n_fields, fields);
>> if (IS_ERR(event)) {
>> ret = PTR_ERR(event);
>> - event = NULL;
>
> This is one of those cases where I rather not touch it.
>
> Yeah, it may not be read, but assigning event to NULL isn't dangerous
> here. And if we change the code to expect event to be NULL or something
> real, it is better to keep this.
OK, makes sense.
>
> -- Steve
>
>
>
>> goto err;
>> }
>> ret = register_synth_event(event);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-17 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 12:37 [PATCH] tracing: remove redundant assignment to pointer 'event' Colin King
2019-06-17 13:42 ` Steven Rostedt
2019-06-17 13:43 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®