* [PATCH] mmc: sdhci-pci: Use dev_get_drvdata
@ 2019-07-23 12:47 Chuhong Yuan
2019-07-24 13:05 ` Adrian Hunter
2019-07-24 14:08 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-07-23 12:47 UTC (permalink / raw)
Cc: Adrian Hunter, Ulf Hansson, linux-mmc, linux-kernel, Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata,
use dev_get_drvdata to make code simpler.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/mmc/host/sdhci-pci-core.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
index 4041878eb0f3..d10aceed5bb7 100644
--- a/drivers/mmc/host/sdhci-pci-core.c
+++ b/drivers/mmc/host/sdhci-pci-core.c
@@ -1759,8 +1759,7 @@ static const struct sdhci_ops sdhci_pci_ops = {
#ifdef CONFIG_PM_SLEEP
static int sdhci_pci_suspend(struct device *dev)
{
- struct pci_dev *pdev = to_pci_dev(dev);
- struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
+ struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
if (!chip)
return 0;
@@ -1773,8 +1772,7 @@ static int sdhci_pci_suspend(struct device *dev)
static int sdhci_pci_resume(struct device *dev)
{
- struct pci_dev *pdev = to_pci_dev(dev);
- struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
+ struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
if (!chip)
return 0;
@@ -1789,8 +1787,7 @@ static int sdhci_pci_resume(struct device *dev)
#ifdef CONFIG_PM
static int sdhci_pci_runtime_suspend(struct device *dev)
{
- struct pci_dev *pdev = to_pci_dev(dev);
- struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
+ struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
if (!chip)
return 0;
@@ -1803,8 +1800,7 @@ static int sdhci_pci_runtime_suspend(struct device *dev)
static int sdhci_pci_runtime_resume(struct device *dev)
{
- struct pci_dev *pdev = to_pci_dev(dev);
- struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
+ struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
if (!chip)
return 0;
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-pci: Use dev_get_drvdata
2019-07-23 12:47 [PATCH] mmc: sdhci-pci: Use dev_get_drvdata Chuhong Yuan
@ 2019-07-24 13:05 ` Adrian Hunter
2019-07-24 14:08 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2019-07-24 13:05 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Ulf Hansson, linux-mmc, linux-kernel
On 23/07/19 3:47 PM, Chuhong Yuan wrote:
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-pci-core.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 4041878eb0f3..d10aceed5bb7 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1759,8 +1759,7 @@ static const struct sdhci_ops sdhci_pci_ops = {
> #ifdef CONFIG_PM_SLEEP
> static int sdhci_pci_suspend(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1773,8 +1772,7 @@ static int sdhci_pci_suspend(struct device *dev)
>
> static int sdhci_pci_resume(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1789,8 +1787,7 @@ static int sdhci_pci_resume(struct device *dev)
> #ifdef CONFIG_PM
> static int sdhci_pci_runtime_suspend(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1803,8 +1800,7 @@ static int sdhci_pci_runtime_suspend(struct device *dev)
>
> static int sdhci_pci_runtime_resume(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-pci: Use dev_get_drvdata
2019-07-23 12:47 [PATCH] mmc: sdhci-pci: Use dev_get_drvdata Chuhong Yuan
2019-07-24 13:05 ` Adrian Hunter
@ 2019-07-24 14:08 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2019-07-24 14:08 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List
On Tue, 23 Jul 2019 at 14:47, Chuhong Yuan <hslester96@gmail.com> wrote:
>
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-pci-core.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 4041878eb0f3..d10aceed5bb7 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1759,8 +1759,7 @@ static const struct sdhci_ops sdhci_pci_ops = {
> #ifdef CONFIG_PM_SLEEP
> static int sdhci_pci_suspend(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1773,8 +1772,7 @@ static int sdhci_pci_suspend(struct device *dev)
>
> static int sdhci_pci_resume(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1789,8 +1787,7 @@ static int sdhci_pci_resume(struct device *dev)
> #ifdef CONFIG_PM
> static int sdhci_pci_runtime_suspend(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1803,8 +1800,7 @@ static int sdhci_pci_runtime_suspend(struct device *dev)
>
> static int sdhci_pci_runtime_resume(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-24 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 12:47 [PATCH] mmc: sdhci-pci: Use dev_get_drvdata Chuhong Yuan
2019-07-24 13:05 ` Adrian Hunter
2019-07-24 14:08 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®