From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>
Cc: Luca Abeni <luca.abeni@santannapisa.it>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Qais Yousef <qais.yousef@arm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] sched/deadline: Fix double accounting in push_dl_task() & some cleanups
Date: Fri, 2 Aug 2019 15:59:42 +0100 [thread overview]
Message-ID: <20190802145945.18702-1-dietmar.eggemann@arm.com> (raw)
While running a simple DL workload (1 DL (12000/100000/100000) task
per CPU) on Arm64 & x86 systems I noticed that some of the
SCHED_WARN_ON() in the rq/running bandwidth (bw) functions trigger.
Patch 1/3 contains a proposal to fix this.
Patch 2-3/3 contain smaller cleanups I discovered while
debugging the actual issue.
Changes v1->v2:
- Remove rq/running bw accounting in pull_dl_task() as well [1/3]
- Remove v1's "sched/deadline: Remove unused int flags from
__dequeue_task_dl()"
- Change return to BUG_ON() in dequeue in !on_dl_rq case [3/3]
- Remove v1's "sched/deadline: Use return value of SCHED_WARN_ON()
in bw accounting"
Dietmar Eggemann (3):
sched/deadline: Fix double accounting of rq/running bw in push & pull
sched/deadline: Use __sub_running_bw() throughout
dl_change_utilization()
sched/deadline: Cleanup on_dl_rq() handling
kernel/sched/deadline.c | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
--
2.17.1
next reply other threads:[~2019-08-02 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 14:59 Dietmar Eggemann [this message]
2019-08-02 14:59 ` [PATCH v2 1/3] sched/deadline: Fix double accounting of rq/running bw in push & pull Dietmar Eggemann
2019-08-06 11:19 ` [tip:sched/urgent] " tip-bot for Dietmar Eggemann
2019-08-02 14:59 ` [PATCH v2 2/3] sched/deadline: Use __sub_running_bw() throughout dl_change_utilization() Dietmar Eggemann
2019-08-02 14:59 ` [PATCH v2 3/3] sched/deadline: Cleanup on_dl_rq() handling Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802145945.18702-1-dietmar.eggemann@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=bristot@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®