* [PATCH] drm/amd/display: Move static keyword to the front of declaration
@ 2019-09-05 18:33 Krzysztof Wilczynski
2019-09-05 18:34 ` Harry Wentland
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Wilczynski @ 2019-09-05 18:33 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, Bhawanpreet Lakha, Tony Cheng, Jun Lei,
David Francis, Nicholas Kazlauskas, Dmytro Laktyushkin,
Wenjing Liu, Anthony Koo, Aidan Wood, Chris Park, Eric Yang,
amd-gfx, dri-devel, linux-kernel
Move the static keyword to the front of declaration of DC_BUILD_ID,
and resolve the following compiler warning that can be seen when
building with warnings enabled (W=1):
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
---
Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com
drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 87ca5a290d12..a5a89bc0e1d1 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -72,7 +72,7 @@
#define DC_LOGGER \
dc->ctx->logger
-const static char DC_BUILD_ID[] = "production-build";
+static const char DC_BUILD_ID[] = "production-build";
/**
* DOC: Overview
--
2.22.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Move static keyword to the front of declaration
2019-09-05 18:33 [PATCH] drm/amd/display: Move static keyword to the front of declaration Krzysztof Wilczynski
@ 2019-09-05 18:34 ` Harry Wentland
0 siblings, 0 replies; 2+ messages in thread
From: Harry Wentland @ 2019-09-05 18:34 UTC (permalink / raw)
To: Krzysztof Wilczynski, David Airlie, Daniel Vetter
Cc: Wentland, Harry, Li, Sun peng (Leo),
Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing),
Lakha, Bhawanpreet, Cheng, Tony, Lei, Jun, Francis, David,
Kazlauskas, Nicholas, Laktyushkin, Dmytro, Liu, Wenjing, Koo,
Anthony, Aidan Wood, Park, Chris, Yang, Eric, amd-gfx, dri-devel,
linux-kernel
On 2019-09-05 2:33 p.m., Krzysztof Wilczynski wrote:
> Move the static keyword to the front of declaration of DC_BUILD_ID,
> and resolve the following compiler warning that can be seen when
> building with warnings enabled (W=1):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com
>
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 87ca5a290d12..a5a89bc0e1d1 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -72,7 +72,7 @@
> #define DC_LOGGER \
> dc->ctx->logger
>
> -const static char DC_BUILD_ID[] = "production-build";
> +static const char DC_BUILD_ID[] = "production-build";
>
> /**
> * DOC: Overview
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-05 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 18:33 [PATCH] drm/amd/display: Move static keyword to the front of declaration Krzysztof Wilczynski
2019-09-05 18:34 ` Harry Wentland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®