* [PATCH 2/5] drm/nouveau/fifo/tu102: make tu102_fifo_runlist static
2019-10-08 11:35 [PATCH 1/5] drm/nouveau/gr/gf100-: make undeclared symbols static Ben Dooks
@ 2019-10-08 11:35 ` Ben Dooks
2019-10-08 11:35 ` [PATCH 3/5] drm/nouveau/fifo/gv100: make gv100_fifo_runlist static Ben Dooks
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2019-10-08 11:35 UTC (permalink / raw)
To: linux-kernel, nouveau, dri-devel
Cc: Ben Skeggs, David Airlie, Daniel Vetter, Ben Dooks
The tu102_fifo_runlist is not exorted, so make it static
to avoid the following warning:
drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu102.c:47:1: warning: symbol 'tu102_fifo_runlist' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu102.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu102.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu102.c
index 005f3e1729b9..3e78f5b6accb 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu102.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu102.c
@@ -43,7 +43,7 @@ tu102_fifo_runlist_commit(struct gk104_fifo *fifo, int runl,
/*XXX: how to wait? can you even wait? */
}
-const struct gk104_fifo_runlist_func
+static const struct gk104_fifo_runlist_func
tu102_fifo_runlist = {
.size = 16,
.cgrp = gv100_fifo_runlist_cgrp,
--
2.23.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 3/5] drm/nouveau/fifo/gv100: make gv100_fifo_runlist static
2019-10-08 11:35 [PATCH 1/5] drm/nouveau/gr/gf100-: make undeclared symbols static Ben Dooks
2019-10-08 11:35 ` [PATCH 2/5] drm/nouveau/fifo/tu102: make tu102_fifo_runlist static Ben Dooks
@ 2019-10-08 11:35 ` Ben Dooks
2019-10-08 11:35 ` [PATCH 4/5] drm/nouveau/disp/gv100: make undeclared symbols static Ben Dooks
2019-10-08 11:35 ` [PATCH 5/5] drm/nouveau/disp/gv100: make gv100_disp_wimm static Ben Dooks
3 siblings, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2019-10-08 11:35 UTC (permalink / raw)
To: linux-kernel, nouveau, dri-devel
Cc: Ben Skeggs, David Airlie, Daniel Vetter, Ben Dooks
Do not export gv100_fifo_runlist as it isn't not used
to remove the following morning:
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c:56:1: warning: symbol 'gv100_fifo_runlist' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c
index 6ee1bb32a071..1f6ddf880179 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c
@@ -52,7 +52,7 @@ gv100_fifo_runlist_cgrp(struct nvkm_fifo_cgrp *cgrp,
nvkm_wo32(memory, offset + 0xc, 0x00000000);
}
-const struct gk104_fifo_runlist_func
+static const struct gk104_fifo_runlist_func
gv100_fifo_runlist = {
.size = 16,
.cgrp = gv100_fifo_runlist_cgrp,
--
2.23.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 4/5] drm/nouveau/disp/gv100: make undeclared symbols static
2019-10-08 11:35 [PATCH 1/5] drm/nouveau/gr/gf100-: make undeclared symbols static Ben Dooks
2019-10-08 11:35 ` [PATCH 2/5] drm/nouveau/fifo/tu102: make tu102_fifo_runlist static Ben Dooks
2019-10-08 11:35 ` [PATCH 3/5] drm/nouveau/fifo/gv100: make gv100_fifo_runlist static Ben Dooks
@ 2019-10-08 11:35 ` Ben Dooks
2019-10-08 11:35 ` [PATCH 5/5] drm/nouveau/disp/gv100: make gv100_disp_wimm static Ben Dooks
3 siblings, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2019-10-08 11:35 UTC (permalink / raw)
To: linux-kernel, nouveau, dri-devel
Cc: Ben Skeggs, David Airlie, Daniel Vetter, Ben Dooks
The two objects gv100_disp_wndw and gv100_disp_wndw_mthd are
not declared or used outside the file, so make them static to
avoid the following warnings:
drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c:120:1: warning: symbol 'gv100_disp_wndw_mthd' was not declared. Should it be static?
drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c:140:1: warning: symbol 'gv100_disp_wndw' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c
index 5d3b641dbb14..e635247d794f 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c
@@ -116,7 +116,7 @@ gv100_disp_wndw_mthd_base = {
}
};
-const struct nv50_disp_chan_mthd
+static const struct nv50_disp_chan_mthd
gv100_disp_wndw_mthd = {
.name = "Window",
.addr = 0x001000,
@@ -136,7 +136,7 @@ gv100_disp_wndw_intr(struct nv50_disp_chan *chan, bool en)
nvkm_mask(device, 0x611da4, mask, data);
}
-const struct nv50_disp_chan_func
+static const struct nv50_disp_chan_func
gv100_disp_wndw = {
.init = gv100_disp_dmac_init,
.fini = gv100_disp_dmac_fini,
--
2.23.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 5/5] drm/nouveau/disp/gv100: make gv100_disp_wimm static
2019-10-08 11:35 [PATCH 1/5] drm/nouveau/gr/gf100-: make undeclared symbols static Ben Dooks
` (2 preceding siblings ...)
2019-10-08 11:35 ` [PATCH 4/5] drm/nouveau/disp/gv100: make undeclared symbols static Ben Dooks
@ 2019-10-08 11:35 ` Ben Dooks
3 siblings, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2019-10-08 11:35 UTC (permalink / raw)
To: linux-kernel, nouveau, dri-devel
Cc: Ben Skeggs, David Airlie, Daniel Vetter, Ben Dooks
The gv100_disp_wimm is not declared, so make it static
to avoid the following warning:
drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
index 89d783368b4f..bb4db6351ddf 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c
@@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en)
nvkm_mask(device, 0x611da8, mask, data);
}
-const struct nv50_disp_chan_func
+static const struct nv50_disp_chan_func
gv100_disp_wimm = {
.init = gv100_disp_dmac_init,
.fini = gv100_disp_dmac_fini,
--
2.23.0
^ permalink raw reply [flat|nested] 5+ messages in thread