From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-kernel@lists.codethink.co.uk
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
"Paul E. McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] rcu: add declarations of undeclared items
Date: Fri, 11 Oct 2019 18:08:24 +0100 [thread overview]
Message-ID: <20191011170824.30228-1-ben.dooks@codethink.co.uk> (raw)
The rcu_state, rcu_rnp_online_cpus and rcu_dynticks_curr_cpu_in_eqs
do not have declarations in a header. Add these to remove the
following sparse warnings:
kernel/rcu/tree.c:87:18: warning: symbol 'rcu_state' was not declared. Should it be static?
kernel/rcu/tree.c:191:15: warning: symbol 'rcu_rnp_online_cpus' was not declared. Should it be static?
kernel/rcu/tree.c:297:6: warning: symbol 'rcu_dynticks_curr_cpu_in_eqs' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
kernel/rcu/tree.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index c612f306fe89..1f88351b9014 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -352,6 +352,8 @@ struct rcu_state {
/* GP pre-initialization. */
};
+extern struct rcu_state rcu_state;
+
/* Values for rcu_state structure's gp_flags field. */
#define RCU_GP_FLAG_INIT 0x1 /* Need grace-period initialization. */
#define RCU_GP_FLAG_FQS 0x2 /* Need grace-period quiescent-state forcing. */
@@ -472,3 +474,7 @@ static void rcu_iw_handler(struct irq_work *iwp);
static void check_cpu_stall(struct rcu_data *rdp);
static void rcu_check_gp_start_stall(struct rcu_node *rnp, struct rcu_data *rdp,
const unsigned long gpssdelay);
+
+extern unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp);
+extern bool rcu_dynticks_curr_cpu_in_eqs(void);
+
--
2.23.0
next reply other threads:[~2019-10-11 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 17:08 Ben Dooks [this message]
2019-10-12 4:44 ` Paul E. McKenney
2019-10-14 7:16 ` Ben Dooks
2019-10-14 17:51 ` Joel Fernandes
2019-10-15 1:41 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011170824.30228-1-ben.dooks@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®