From: Ben Dooks <ben.dooks@codethink.co.uk>
To: paulmck@kernel.org
Cc: linux-kernel@lists.codethink.co.uk,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: add declarations of undeclared items
Date: Mon, 14 Oct 2019 08:16:58 +0100 [thread overview]
Message-ID: <7acbcc9b901304f8f55cc1cece802785@codethink.co.uk> (raw)
In-Reply-To: <20191012044430.GG2689@paulmck-ThinkPad-P72>
On 2019-10-12 05:44, Paul E. McKenney wrote:
> On Fri, Oct 11, 2019 at 06:08:24PM +0100, Ben Dooks wrote:
>> The rcu_state, rcu_rnp_online_cpus and rcu_dynticks_curr_cpu_in_eqs
>> do not have declarations in a header. Add these to remove the
>> following sparse warnings:
>>
>> kernel/rcu/tree.c:87:18: warning: symbol 'rcu_state' was not declared.
>> Should it be static?
>> kernel/rcu/tree.c:191:15: warning: symbol 'rcu_rnp_online_cpus' was
>> not declared. Should it be static?
>> kernel/rcu/tree.c:297:6: warning: symbol
>> 'rcu_dynticks_curr_cpu_in_eqs' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>
> Good catch!
>
> However, these guys (plus one more) are actually used only in the
> kernel/rcu/tree.o translation unit, so they can be marked static.
> I made this change as shown below with your Reported-by.
>
> Seem reasonable?
yes, thanks.
next prev parent reply other threads:[~2019-10-14 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 17:08 Ben Dooks
2019-10-12 4:44 ` Paul E. McKenney
2019-10-14 7:16 ` Ben Dooks [this message]
2019-10-14 17:51 ` Joel Fernandes
2019-10-15 1:41 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7acbcc9b901304f8f55cc1cece802785@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome