[PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

[PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

[Uwe Kleine-König]

This extension was introduced in commit 57f5677e535b ("printf: add
support for printing symbolic error names").

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6fcc66afb088..31cd9b767c1e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6022,7 +6022,7 @@ sub process {
 				while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
 					$specifier = $1;
 					$extension = $2;
-					if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
+					if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
 						$bad_specifier = $specifier;
 						last;
 					}
-- 
2.24.0

Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

[Rasmus Villemoes]

On 14/11/2019 11.04, Uwe Kleine-König wrote:
> This extension was introduced in commit 57f5677e535b ("printf: add
> support for printing symbolic error names").
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Ack, of course. Petr, I think it makes most sense if this goes via your
tree unless there are other checkpatch patches touching the same place
(which I doubt, as I think we'd know about other new extensions).

Rasmus

Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

[Petr Mladek]

On Thu 2019-11-14 11:04:16, Uwe Kleine-König wrote:
> This extension was introduced in commit 57f5677e535b ("printf: add
> support for printing symbolic error names").

Great catch!

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6fcc66afb088..31cd9b767c1e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6022,7 +6022,7 @@ sub process {
>  				while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
>  					$specifier = $1;
>  					$extension = $2;
> -					if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> +					if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {

I am going to push it into printk.git. I will just change the ordering
"eE" -> "Ee". So that it follows the existing convention.

Best Regards,
Petr

Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

[Uwe Kleine-König]

On Thu, Nov 14, 2019 at 11:24:40AM +0100, Petr Mladek wrote:
> On Thu 2019-11-14 11:04:16, Uwe Kleine-König wrote:
> > This extension was introduced in commit 57f5677e535b ("printf: add
> > support for printing symbolic error names").
> 
> Great catch!

It wasn't hard to catch. checkpatch pelted me with bogus warnings when I
started to make use of %pe :-)

> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  scripts/checkpatch.pl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 6fcc66afb088..31cd9b767c1e 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -6022,7 +6022,7 @@ sub process {
> >  				while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> >  					$specifier = $1;
> >  					$extension = $2;
> > -					if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> > +					if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
> 
> I am going to push it into printk.git. I will just change the ordering
> "eE" -> "Ee". So that it follows the existing convention.

Fine for me. Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

[Petr Mladek]

On Thu 2019-11-14 11:33:50, Uwe Kleine-König wrote:
> On Thu, Nov 14, 2019 at 11:24:40AM +0100, Petr Mladek wrote:
> > On Thu 2019-11-14 11:04:16, Uwe Kleine-König wrote:
> > > This extension was introduced in commit 57f5677e535b ("printf: add
> > > support for printing symbolic error names").
> > 
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > index 6fcc66afb088..31cd9b767c1e 100755
> > > --- a/scripts/checkpatch.pl
> > > +++ b/scripts/checkpatch.pl
> > > @@ -6022,7 +6022,7 @@ sub process {
> > >  				while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> > >  					$specifier = $1;
> > >  					$extension = $2;
> > > -					if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> > > +					if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
> > 
> > I am going to push it into printk.git. I will just change the ordering
> > "eE" -> "Ee". So that it follows the existing convention.
> 
> Fine for me. Thanks

The patch is committed in printk.git, branch for-5.5.

Best Regards,
Petr