mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as __exit
@ 2019-12-16 19:48 Arnd Bergmann
  2019-12-17  8:00 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-12-16 19:48 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Arnd Bergmann, kbuild test robot, kernelci . org bot,
	Olof's autobuilder, Stephen Rothwell, Karsten Keil,
	David Miller, netdev, linux-kernel

As everybody pointed out by now, my patch to clean up CAPI introduced
a link time warning, as the two parts of the capi driver are now in
one module and the exit function may need to be called in the error
path of the init function:

>> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit()
   The function kcapi_exit() references a function in an exit section.
   Often the function kcapi_proc_exit() has valid usage outside the exit section
   and the fix is to remove the __exit annotation of kcapi_proc_exit.

Remove the incorrect __exit annotation.

Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: kernelci.org bot <bot@kernelci.org>
Reported-by: Olof's autobuilder <build@lixom.net>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/isdn/capi/kcapi_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/capi/kcapi_proc.c b/drivers/isdn/capi/kcapi_proc.c
index 2bffbb8bf271..eadbe59b3753 100644
--- a/drivers/isdn/capi/kcapi_proc.c
+++ b/drivers/isdn/capi/kcapi_proc.c
@@ -217,7 +217,7 @@ kcapi_proc_init(void)
 	proc_create("capi/driver",           0, NULL, &empty_fops);
 }
 
-void __exit
+void
 kcapi_proc_exit(void)
 {
 	remove_proc_entry("capi/driver",       NULL);
-- 
2.20.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as __exit
  2019-12-16 19:48 [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as __exit Arnd Bergmann
@ 2019-12-17  8:00 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-12-17  8:00 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: kbuild test robot, kernelci . org bot, Olof's autobuilder,
	Stephen Rothwell, Karsten Keil, David Miller, netdev,
	linux-kernel

On Mon, Dec 16, 2019 at 08:48:56PM +0100, Arnd Bergmann wrote:
> As everybody pointed out by now, my patch to clean up CAPI introduced
> a link time warning, as the two parts of the capi driver are now in
> one module and the exit function may need to be called in the error
> path of the init function:
> 
> >> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit()
>    The function kcapi_exit() references a function in an exit section.
>    Often the function kcapi_proc_exit() has valid usage outside the exit section
>    and the fix is to remove the __exit annotation of kcapi_proc_exit.
> 
> Remove the incorrect __exit annotation.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/isdn/capi/kcapi_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for this, now applied.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-17  8:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 19:48 [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as __exit Arnd Bergmann
2019-12-17  8:00 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®