From: David Miller <davem@davemloft.net>
To: po.liu@nxp.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
vinicius.gomes@intel.com, claudiu.manoil@nxp.com,
vladimir.oltean@nxp.com, alexandru.marginean@nxp.com,
xiaoliang.yang_1@nxp.com, roy.zang@nxp.com, mingkai.hu@nxp.com,
jerry.huang@nxp.com, leoyang.li@nxp.com,
ivan.khoronzhuk@linaro.org
Subject: Re: [net-next] enetc: add support time specific departure base on the qos etf
Date: Thu, 26 Dec 2019 15:09:41 -0800 (PST) [thread overview]
Message-ID: <20191226.150941.618022568387879445.davem@davemloft.net> (raw)
In-Reply-To: <20191223032618.18205-1-Po.Liu@nxp.com>
From: Po Liu <po.liu@nxp.com>
Date: Mon, 23 Dec 2019 03:42:39 +0000
> - Transmit checksum offloads and time specific departure operation
> are mutually exclusive.
I do not see anything which enforces this conflict.
It looks to me like if the user configures time specific departure,
and TX SKBs will be checksum offloaded, the time specific departure
will simply not be performed.
If true, this behavior will be very surprising for the user.
Instead, the configuration operation that creates the conflict should
throw and error and fail.
Thank you.
next prev parent reply other threads:[~2019-12-26 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 3:42 Po Liu
2019-12-26 23:09 ` David Miller [this message]
2019-12-27 2:11 ` [EXT] " Po Liu
2019-12-27 3:12 ` [v2,net-next] " Po Liu
2019-12-31 4:26 ` David Miller
2020-01-02 2:16 ` [EXT] " Po Liu
2020-01-02 4:59 ` [v3,net-next] " Po Liu
2020-01-03 0:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226.150941.618022568387879445.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandru.marginean@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jerry.huang@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingkai.hu@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=roy.zang@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®