From: David Miller <davem@davemloft.net>
To: po.liu@nxp.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
vinicius.gomes@intel.com, claudiu.manoil@nxp.com,
vladimir.oltean@nxp.com, alexandru.marginean@nxp.com,
xiaoliang.yang_1@nxp.com, roy.zang@nxp.com, mingkai.hu@nxp.com,
jerry.huang@nxp.com, leoyang.li@nxp.com,
ivan.khoronzhuk@linaro.org
Subject: Re: [v2,net-next] enetc: add support time specific departure base on the qos etf
Date: Mon, 30 Dec 2019 20:26:52 -0800 (PST) [thread overview]
Message-ID: <20191230.202652.128958107020164612.davem@davemloft.net> (raw)
In-Reply-To: <20191227025547.4452-1-Po.Liu@nxp.com>
From: Po Liu <po.liu@nxp.com>
Date: Fri, 27 Dec 2019 03:12:18 +0000
> v2:
> - fix the csum and time specific deaprture return directly if both
> offloading enabled
The test is in the wrong location.
You are testing at run time when packets are being transmitted.
Instead, you should test when the configuration change is made
which creates the conflict, and disallow the configuration change
in such a conflicting case.
next prev parent reply other threads:[~2019-12-31 4:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 3:42 [net-next] " Po Liu
2019-12-26 23:09 ` David Miller
2019-12-27 2:11 ` [EXT] " Po Liu
2019-12-27 3:12 ` [v2,net-next] " Po Liu
2019-12-31 4:26 ` David Miller [this message]
2020-01-02 2:16 ` [EXT] " Po Liu
2020-01-02 4:59 ` [v3,net-next] " Po Liu
2020-01-03 0:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230.202652.128958107020164612.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandru.marginean@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jerry.huang@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingkai.hu@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=roy.zang@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®