From: David Miller <davem@davemloft.net>
To: po.liu@nxp.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
vinicius.gomes@intel.com, claudiu.manoil@nxp.com,
vladimir.oltean@nxp.com, alexandru.marginean@nxp.com,
xiaoliang.yang_1@nxp.com, roy.zang@nxp.com, mingkai.hu@nxp.com,
jerry.huang@nxp.com, leoyang.li@nxp.com,
ivan.khoronzhuk@linaro.org
Subject: Re: [v3,net-next] enetc: add support time specific departure base on the qos etf
Date: Thu, 02 Jan 2020 16:33:02 -0800 (PST) [thread overview]
Message-ID: <20200102.163302.1487790740822950185.davem@davemloft.net> (raw)
In-Reply-To: <20200102044300.29951-1-Po.Liu@nxp.com>
From: Po Liu <po.liu@nxp.com>
Date: Thu, 2 Jan 2020 04:59:24 +0000
> ENETC implement time specific departure capability, which enables
> the user to specify when a frame can be transmitted. When this
> capability is enabled, the device will delay the transmission of
> the frame so that it can be transmitted at the precisely specified time.
> The delay departure time up to 0.5 seconds in the future. If the
> departure time in the transmit BD has not yet been reached, based
> on the current time, the packet will not be transmitted.
>
> This driver was loaded by Qos driver ETF. User could load it by tc
> commands. Here are the example commands:
>
> tc qdisc add dev eth0 root handle 1: mqprio \
> num_tc 8 map 0 1 2 3 4 5 6 7 hw 1
> tc qdisc replace dev eth0 parent 1:8 etf \
> clockid CLOCK_TAI delta 30000 offload
>
> These example try to set queue mapping first and then set queue 7
> with 30us ahead dequeue time.
>
> Then user send test frame should set SO_TXTIME feature for socket.
>
> There are also some limitations for this feature in hardware:
> - Transmit checksum offloads and time specific departure operation
> are mutually exclusive.
> - Time Aware Shaper feature (Qbv) offload and time specific departure
> operation are mutually exclusive.
>
> Signed-off-by: Po Liu <Po.Liu@nxp.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> Changes v2-v3:
> - Avoid tx checking sum offload when setting TXTIME offload. This is
> not support in hardware.
This looks a lot better, applied, thank you.
prev parent reply other threads:[~2020-01-03 0:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 3:42 [net-next] " Po Liu
2019-12-26 23:09 ` David Miller
2019-12-27 2:11 ` [EXT] " Po Liu
2019-12-27 3:12 ` [v2,net-next] " Po Liu
2019-12-31 4:26 ` David Miller
2020-01-02 2:16 ` [EXT] " Po Liu
2020-01-02 4:59 ` [v3,net-next] " Po Liu
2020-01-03 0:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102.163302.1487790740822950185.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandru.marginean@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jerry.huang@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingkai.hu@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=roy.zang@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®