* [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate
@ 2020-01-07 1:03 John Stultz
2020-01-07 1:38 ` Bjorn Andersson
2020-01-07 8:32 ` Philipp Zabel
0 siblings, 2 replies; 4+ messages in thread
From: John Stultz @ 2020-01-07 1:03 UTC (permalink / raw)
To: lkml
Cc: John Stultz, Todd Kjos, Alistair Delva, Bjorn Andersson,
Amit Pundir, Philipp Zabel
Allow CONFIG_RESET_QCOM_AOSS to be set as as =m
to allow for the driver to be loaded from a modules.
Cc: Todd Kjos <tkjos@google.com>
Cc: Alistair Delva <adelva@google.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Amit Pundir <amit.pundir@linaro.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
drivers/reset/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 3ad7817ce1f0..45e70524af36 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -99,7 +99,7 @@ config RESET_PISTACHIO
This enables the reset driver for ImgTec Pistachio SoCs.
config RESET_QCOM_AOSS
- bool "Qcom AOSS Reset Driver"
+ tristate "Qcom AOSS Reset Driver"
depends on ARCH_QCOM || COMPILE_TEST
help
This enables the AOSS (always on subsystem) reset driver
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate
2020-01-07 1:03 [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate John Stultz
@ 2020-01-07 1:38 ` Bjorn Andersson
2020-01-07 8:32 ` Philipp Zabel
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-01-07 1:38 UTC (permalink / raw)
To: John Stultz; +Cc: lkml, Todd Kjos, Alistair Delva, Amit Pundir, Philipp Zabel
On Mon 06 Jan 17:03 PST 2020, John Stultz wrote:
> Allow CONFIG_RESET_QCOM_AOSS to be set as as =m
> to allow for the driver to be loaded from a modules.
>
> Cc: Todd Kjos <tkjos@google.com>
> Cc: Alistair Delva <adelva@google.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Amit Pundir <amit.pundir@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> drivers/reset/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 3ad7817ce1f0..45e70524af36 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -99,7 +99,7 @@ config RESET_PISTACHIO
> This enables the reset driver for ImgTec Pistachio SoCs.
>
> config RESET_QCOM_AOSS
> - bool "Qcom AOSS Reset Driver"
> + tristate "Qcom AOSS Reset Driver"
> depends on ARCH_QCOM || COMPILE_TEST
> help
> This enables the AOSS (always on subsystem) reset driver
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate
2020-01-07 1:03 [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate John Stultz
2020-01-07 1:38 ` Bjorn Andersson
@ 2020-01-07 8:32 ` Philipp Zabel
2020-01-07 17:23 ` John Stultz
1 sibling, 1 reply; 4+ messages in thread
From: Philipp Zabel @ 2020-01-07 8:32 UTC (permalink / raw)
To: John Stultz, lkml; +Cc: Todd Kjos, Alistair Delva, Bjorn Andersson, Amit Pundir
On Tue, 2020-01-07 at 01:03 +0000, John Stultz wrote:
> Allow CONFIG_RESET_QCOM_AOSS to be set as as =m
> to allow for the driver to be loaded from a modules.
>
> Cc: Todd Kjos <tkjos@google.com>
> Cc: Alistair Delva <adelva@google.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Amit Pundir <amit.pundir@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> drivers/reset/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 3ad7817ce1f0..45e70524af36 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -99,7 +99,7 @@ config RESET_PISTACHIO
> This enables the reset driver for ImgTec Pistachio SoCs.
>
> config RESET_QCOM_AOSS
> - bool "Qcom AOSS Reset Driver"
> + tristate "Qcom AOSS Reset Driver"
This doesn't seem right on its own, the driver still uses
builtin_platform_driver().
regards
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate
2020-01-07 8:32 ` Philipp Zabel
@ 2020-01-07 17:23 ` John Stultz
0 siblings, 0 replies; 4+ messages in thread
From: John Stultz @ 2020-01-07 17:23 UTC (permalink / raw)
To: Philipp Zabel
Cc: lkml, Todd Kjos, Alistair Delva, Bjorn Andersson, Amit Pundir
On Tue, Jan 7, 2020 at 12:32 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Tue, 2020-01-07 at 01:03 +0000, John Stultz wrote:
> > Allow CONFIG_RESET_QCOM_AOSS to be set as as =m
> > to allow for the driver to be loaded from a modules.
> >
> > Cc: Todd Kjos <tkjos@google.com>
> > Cc: Alistair Delva <adelva@google.com>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: Amit Pundir <amit.pundir@linaro.org>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: John Stultz <john.stultz@linaro.org>
> > ---
> > drivers/reset/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 3ad7817ce1f0..45e70524af36 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -99,7 +99,7 @@ config RESET_PISTACHIO
> > This enables the reset driver for ImgTec Pistachio SoCs.
> >
> > config RESET_QCOM_AOSS
> > - bool "Qcom AOSS Reset Driver"
> > + tristate "Qcom AOSS Reset Driver"
>
> This doesn't seem right on its own, the driver still uses
> builtin_platform_driver().
Huh. Thanks for pointing that out!
It seems like it was working fine as a module with just the kconfig
change, but let me double check this and I'll revise with a follow-on
patch to address this bit.
Very much appreciate the review!
thanks
-john
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-07 17:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 1:03 [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate John Stultz
2020-01-07 1:38 ` Bjorn Andersson
2020-01-07 8:32 ` Philipp Zabel
2020-01-07 17:23 ` John Stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®