* [PATCH 1/4] tty: synclink_gt: use true,false for bool variable
2019-12-24 9:38 [PATCH 0/4] tty: use true,false for bool variable zhengbin
@ 2019-12-24 9:38 ` zhengbin
2019-12-24 9:38 ` [PATCH 2/4] tty/serial: kgdb_nmi: " zhengbin
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-12-24 9:38 UTC (permalink / raw)
To: gregkh, jslaby, linux-kernel; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/tty/synclink_gt.c:2101:3-19: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/tty/synclink_gt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c
index 5759b6c..eebf10b 100644
--- a/drivers/tty/synclink_gt.c
+++ b/drivers/tty/synclink_gt.c
@@ -2098,7 +2098,7 @@ static void isr_rxdata(struct slgt_info *info)
if (desc_complete(info->rbufs[i])) {
/* all buffers full */
rx_stop(info);
- info->rx_restart = 1;
+ info->rx_restart = true;
continue;
}
info->rbufs[i].buf[count++] = (unsigned char)reg;
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/4] tty/serial: kgdb_nmi: use true,false for bool variable
2019-12-24 9:38 [PATCH 0/4] tty: use true,false for bool variable zhengbin
2019-12-24 9:38 ` [PATCH 1/4] tty: synclink_gt: " zhengbin
@ 2019-12-24 9:38 ` zhengbin
2019-12-24 9:38 ` [PATCH 3/4] tty/serial: atmel: " zhengbin
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-12-24 9:38 UTC (permalink / raw)
To: gregkh, jslaby, linux-kernel; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/tty/serial/kgdb_nmi.c:121:6-13: WARNING: Assignment of 0/1 to bool variable
drivers/tty/serial/kgdb_nmi.c:133:2-9: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/tty/serial/kgdb_nmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c
index 4029272..5022447 100644
--- a/drivers/tty/serial/kgdb_nmi.c
+++ b/drivers/tty/serial/kgdb_nmi.c
@@ -118,7 +118,7 @@ static int kgdb_nmi_poll_one_knock(void)
int c = -1;
const char *magic = kgdb_nmi_magic;
size_t m = strlen(magic);
- bool printch = 0;
+ bool printch = false;
c = dbg_io_ops->read_char();
if (c == NO_POLL_CHAR)
@@ -130,7 +130,7 @@ static int kgdb_nmi_poll_one_knock(void)
n = (n + 1) % m;
if (!n)
return 1;
- printch = 1;
+ printch = true;
} else {
n = 0;
}
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/4] tty/serial: atmel: use true,false for bool variable
2019-12-24 9:38 [PATCH 0/4] tty: use true,false for bool variable zhengbin
2019-12-24 9:38 ` [PATCH 1/4] tty: synclink_gt: " zhengbin
2019-12-24 9:38 ` [PATCH 2/4] tty/serial: kgdb_nmi: " zhengbin
@ 2019-12-24 9:38 ` zhengbin
2019-12-24 9:38 ` [PATCH 4/4] tty/serial: 8250_exar: " zhengbin
2020-01-11 19:47 ` [PATCH 0/4] tty: " Greg KH
4 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-12-24 9:38 UTC (permalink / raw)
To: gregkh, jslaby, linux-kernel; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/tty/serial/atmel_serial.c:1062:1-23: WARNING: Assignment of 0/1 to bool variable
drivers/tty/serial/atmel_serial.c:1261:1-23: WARNING: Assignment of 0/1 to bool variable
drivers/tty/serial/atmel_serial.c:1688:3-25: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/tty/serial/atmel_serial.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index fa19eb3..181da0c 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -1059,7 +1059,7 @@ static int atmel_prepare_tx_dma(struct uart_port *port)
chan_err:
dev_err(port->dev, "TX channel not available, switch to pio\n");
- atmel_port->use_dma_tx = 0;
+ atmel_port->use_dma_tx = false;
if (atmel_port->chan_tx)
atmel_release_tx_dma(port);
return -EINVAL;
@@ -1258,7 +1258,7 @@ static int atmel_prepare_rx_dma(struct uart_port *port)
chan_err:
dev_err(port->dev, "RX channel not available, switch to pio\n");
- atmel_port->use_dma_rx = 0;
+ atmel_port->use_dma_rx = false;
if (atmel_port->chan_rx)
atmel_release_rx_dma(port);
return -EINVAL;
@@ -1685,7 +1685,7 @@ static int atmel_prepare_rx_pdc(struct uart_port *port)
DMA_FROM_DEVICE);
kfree(atmel_port->pdc_rx[0].buf);
}
- atmel_port->use_pdc_rx = 0;
+ atmel_port->use_pdc_rx = false;
return -ENOMEM;
}
pdc->dma_addr = dma_map_single(port->dev,
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/4] tty/serial: 8250_exar: use true,false for bool variable
2019-12-24 9:38 [PATCH 0/4] tty: use true,false for bool variable zhengbin
` (2 preceding siblings ...)
2019-12-24 9:38 ` [PATCH 3/4] tty/serial: atmel: " zhengbin
@ 2019-12-24 9:38 ` zhengbin
2020-01-11 19:47 ` [PATCH 0/4] tty: " Greg KH
4 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-12-24 9:38 UTC (permalink / raw)
To: gregkh, jslaby, linux-kernel; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/tty/serial/8250/8250_exar.c:189:6-17: WARNING: Assignment of 0/1 to bool variable
drivers/tty/serial/8250/8250_exar.c:197:3-14: WARNING: Assignment of 0/1 to bool variable
drivers/tty/serial/8250/8250_exar.c:199:3-14: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/tty/serial/8250/8250_exar.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 108cd55..91e9b07 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -186,7 +186,7 @@ static int xr17v35x_startup(struct uart_port *port)
static void exar_shutdown(struct uart_port *port)
{
unsigned char lsr;
- bool tx_complete = 0;
+ bool tx_complete = false;
struct uart_8250_port *up = up_to_u8250p(port);
struct circ_buf *xmit = &port->state->xmit;
int i = 0;
@@ -194,9 +194,9 @@ static void exar_shutdown(struct uart_port *port)
do {
lsr = serial_in(up, UART_LSR);
if (lsr & (UART_LSR_TEMT | UART_LSR_THRE))
- tx_complete = 1;
+ tx_complete = true;
else
- tx_complete = 0;
+ tx_complete = false;
usleep_range(1000, 1100);
} while (!uart_circ_empty(xmit) && !tx_complete && i++ < 1000);
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/4] tty: use true,false for bool variable
2019-12-24 9:38 [PATCH 0/4] tty: use true,false for bool variable zhengbin
` (3 preceding siblings ...)
2019-12-24 9:38 ` [PATCH 4/4] tty/serial: 8250_exar: " zhengbin
@ 2020-01-11 19:47 ` Greg KH
4 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-01-11 19:47 UTC (permalink / raw)
To: zhengbin; +Cc: jslaby, linux-kernel
On Tue, Dec 24, 2019 at 05:38:01PM +0800, zhengbin wrote:
> zhengbin (4):
I need a "real" name here, one that you use to sign documents.
Can you fix that up for all 4 of these patches and resend the series?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread