* [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq()
@ 2020-02-04 11:36 Thomas Bogendoerfer
2020-02-04 11:44 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Bogendoerfer @ 2020-02-04 11:36 UTC (permalink / raw)
To: David S. Miller
Cc: Ralf Baechle, Paul Burton, linux-mips, netdev, linux-kernel
Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved
request_irq() from ioc3_open into probe function, but forgot to remove
free_irq() from ioc3_close.
Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
drivers/net/ethernet/sgi/ioc3-eth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c
index e61eb891c0f7..db6b2988e632 100644
--- a/drivers/net/ethernet/sgi/ioc3-eth.c
+++ b/drivers/net/ethernet/sgi/ioc3-eth.c
@@ -823,7 +823,6 @@ static int ioc3_close(struct net_device *dev)
netif_stop_queue(dev);
ioc3_stop(ip);
- free_irq(dev->irq, dev);
ioc3_free_rx_bufs(ip);
ioc3_clean_tx_ring(ip);
--
2.24.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq()
2020-02-04 11:36 [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq() Thomas Bogendoerfer
@ 2020-02-04 11:44 ` David Miller
2020-02-04 11:58 ` Thomas Bogendoerfer
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2020-02-04 11:44 UTC (permalink / raw)
To: tbogendoerfer; +Cc: ralf, paulburton, linux-mips, netdev, linux-kernel
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Date: Tue, 4 Feb 2020 12:36:28 +0100
> Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved
> request_irq() from ioc3_open into probe function, but forgot to remove
> free_irq() from ioc3_close.
>
> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
ioc3_open() still has the request_irq() in my tree.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq()
2020-02-04 11:44 ` David Miller
@ 2020-02-04 11:58 ` Thomas Bogendoerfer
2020-02-04 13:42 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Bogendoerfer @ 2020-02-04 11:58 UTC (permalink / raw)
To: David Miller; +Cc: ralf, paulburton, linux-mips, netdev, linux-kernel
On Tue, 04 Feb 2020 12:44:55 +0100 (CET)
David Miller <davem@davemloft.net> wrote:
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> Date: Tue, 4 Feb 2020 12:36:28 +0100
>
> > Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved
> > request_irq() from ioc3_open into probe function, but forgot to remove
> > free_irq() from ioc3_close.
> >
> > Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> ioc3_open() still has the request_irq() in my tree.
then I guess you don't have commit 0ce5ebd24d25 in your tree. My Patch is
against linus/master, where it is already applied. Should I rebase against your
net tree, when the commit shows up ?
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq()
2020-02-04 11:58 ` Thomas Bogendoerfer
@ 2020-02-04 13:42 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-02-04 13:42 UTC (permalink / raw)
To: tbogendoerfer; +Cc: ralf, paulburton, linux-mips, netdev, linux-kernel
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Date: Tue, 4 Feb 2020 12:58:33 +0100
> On Tue, 04 Feb 2020 12:44:55 +0100 (CET)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>> Date: Tue, 4 Feb 2020 12:36:28 +0100
>>
>> > Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved
>> > request_irq() from ioc3_open into probe function, but forgot to remove
>> > free_irq() from ioc3_close.
>> >
>> > Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
>> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>>
>> ioc3_open() still has the request_irq() in my tree.
>
> then I guess you don't have commit 0ce5ebd24d25 in your tree. My Patch is
> against linus/master, where it is already applied. Should I rebase against your
> net tree, when the commit shows up ?
I just sync'd with Linus's tree so you should be able to rebase right now.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-04 13:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 11:36 [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq() Thomas Bogendoerfer
2020-02-04 11:44 ` David Miller
2020-02-04 11:58 ` Thomas Bogendoerfer
2020-02-04 13:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®