From: Steven Rostedt <rostedt@goodmis.org>
To: Kees Cook <keescook@chromium.org>
Cc: Mark Salyzyn <salyzyn@android.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Richard Henderson <richard.henderson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Thomas Gleixner <tglx@linutronix.de>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH] random: add rng-seed= command line option
Date: Fri, 7 Feb 2020 12:47:44 -0500 [thread overview]
Message-ID: <20200207124744.08a2f4d5@oasis.local.home> (raw)
In-Reply-To: <202002070850.BD92BDCA@keescook>
On Fri, 7 Feb 2020 09:28:27 -0800
Kees Cook <keescook@chromium.org> wrote:
> > static void __init setup_command_line(char *command_line)
> > {
> > size_t len, xlen = 0, ilen = 0;
> > + static const char argsep_str[] __initconst = " -- ";
> > + static const char alloc_fail_msg[] __initconst =
> > + "%s: Failed to allocate %zu bytes\n";
>
> There's some refactoring in this patch unrelated to the seed logic. Can
> you split that out? (I think these changes are good.)
>
> >
> > if (extra_command_line)
> > xlen = strlen(extra_command_line);
>
> Unrelated note: whoa this is based on linux-next which has a massive
> change to the boot command line handling and appears to be doing some
> bad things. I need to go find that thread...
This would be Masami's bootconfig work which Linus already pulled in.
What bad things are there? You can see the thread here:
http://lore.kernel.org/r/157867220019.17873.13377985653744804396.stgit@devnote2
http://lore.kernel.org/r/CAHk-=wjfjO+h6bQzrTf=YCZA53Y3EDyAs3Z4gEsT7icA3u_Psw@mail.gmail.com
-- Steve
next prev parent reply other threads:[~2020-02-07 17:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 15:07 Mark Salyzyn
2020-02-07 15:58 ` Theodore Y. Ts'o
2020-02-07 17:49 ` Mark Salyzyn
2020-02-08 0:49 ` Theodore Y. Ts'o
2020-02-08 0:53 ` Steven Rostedt
2020-02-13 11:24 ` Masami Hiramatsu
2020-02-13 15:03 ` Masami Hiramatsu
2020-02-13 18:44 ` Mark Salyzyn
2020-02-14 1:16 ` Masami Hiramatsu
2020-02-14 17:02 ` Mark Salyzyn
2020-02-10 12:13 ` Mark Brown
2020-02-11 15:07 ` Theodore Y. Ts'o
2020-02-10 14:45 ` [PATCH 0/4 v2] random add rng-seed to " Mark Salyzyn
2020-02-10 14:45 ` [PATCH 1/4 v2] init: move string constants to __initconst section Mark Salyzyn
2020-02-10 14:45 ` [PATCH 2/4 v2] init: boot_command_line can be truncated Mark Salyzyn
2020-02-10 14:45 ` [PATCH 3/4 v2] random: rng-seed source is utf-8 Mark Salyzyn
2020-02-10 14:45 ` [PATCH 4/4 v2] random: add rng-seed= command line option Mark Salyzyn
2020-02-10 21:40 ` Randy Dunlap
2020-02-10 22:19 ` [PATCH 4/4 v3] " Mark Salyzyn
2020-02-07 17:28 ` [PATCH] " Kees Cook
2020-02-07 17:47 ` Steven Rostedt [this message]
2020-02-07 17:58 ` Mark Salyzyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207124744.08a2f4d5@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsinyi@chromium.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mhiramat@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=richard.henderson@linaro.org \
--cc=rppt@linux.ibm.com \
--cc=salyzyn@android.com \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®