mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] trace: Move trace data to new section _ftrace_data
Date: Tue, 18 Feb 2020 21:53:28 -0500	[thread overview]
Message-ID: <20200218215328.16744447@gandalf.local.home> (raw)
In-Reply-To: <cover.1582077698.git.joe@perches.com>

On Tue, 18 Feb 2020 18:03:16 -0800
Joe Perches <joe@perches.com> wrote:

> Move the trace data to a separate section to make it easier to
> examine the amount of actual data in an object file.

Not that I'm against this patch set, but can you elaborate more on
"make it easier to examine the amount of actual data in an object file".

Also, don't use "_ftrace" as the section name. "ftrace" should be
reserved for the function hook part of tracing, which trace events do
not apply to. "_trace_event_data" would be more appropriate.

-- Steve


> 
> Joe Perches (2):
>   trace: Move data to new section _ftrace_data
>   trace_events/trace_export: Use __section
> 
>  include/trace/trace_events.h | 36 +++++++++++++++++++++---------------
>  kernel/trace/trace_export.c  | 13 ++++++++-----
>  2 files changed, 29 insertions(+), 20 deletions(-)
> 


  parent reply	other threads:[~2020-02-19  2:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  2:03 Joe Perches
2020-02-19  2:03 ` [RFC PATCH 1/2] trace: Move " Joe Perches
2020-02-19  2:03 ` [RFC PATCH 2/2] trace_events/trace_export: Use __section Joe Perches
2020-02-19  2:53 ` Steven Rostedt [this message]
2020-02-19  3:09   ` [RFC PATCH 0/2] trace: Move trace data to new section _ftrace_data Joe Perches
2020-02-19  3:26     ` Steven Rostedt
2020-02-19  3:33       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218215328.16744447@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®