From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] trace: Move trace data to new section _ftrace_data
Date: Tue, 18 Feb 2020 19:33:08 -0800 [thread overview]
Message-ID: <658fe8a43c01360813d11087ea974b12c02bb6b4.camel@perches.com> (raw)
In-Reply-To: <20200218222615.713d542d@gandalf.local.home>
On Tue, 2020-02-18 at 22:26 -0500, Steven Rostedt wrote:
> On Tue, 18 Feb 2020 19:09:10 -0800
> Joe Perches <joe@perches.com> wrote:
>
> > I don't care about the section name at all.
> >
> > I used that name for consistency with _ftrace_event
> > in the same file.
> > Perhaps the _ftrace_event section
> > name could be renamed to something
> > intelligible too.
>
> Yes, that should probably get changed. That's a leftover when we just
> called everything "ftrace", but it should have been changed when I
> renamed the file from ftrace.h to trace_event.h.
Pick a name.
btw: it's not used in an x86-64 allmodconfig or defconfig
as an actual separate section as far as I tell.
$ git grep _ftrace_events
include/asm-generic/vmlinux.lds.h: __start_ftrace_events = .; \
include/asm-generic/vmlinux.lds.h: KEEP(*(_ftrace_events)) \
include/asm-generic/vmlinux.lds.h: __stop_ftrace_events = .; \
include/linux/syscalls.h: __attribute__((section("_ftrace_events"))) \
include/linux/syscalls.h: __attribute__((section("_ftrace_events"))) \
include/trace/trace_events.h: * __section(_ftrace_events) *__event_<call> = &event_<call>;
include/trace/trace_events.h:static struct trace_event_call __used __section(_ftrace_events) \
include/trace/trace_events.h:static struct trace_event_call __used __section(_ftrace_events) \
kernel/module.c: mod->trace_events = section_objs(info, "_ftrace_events",
kernel/trace/trace_events.c:extern struct trace_event_call *__start_ftrace_events[];
kernel/trace/trace_events.c:extern struct trace_event_call *__stop_ftrace_events[];
kernel/trace/trace_events.c: for_each_event(iter, __start_ftrace_events, __stop_ftrace_events) {
kernel/trace/trace_export.c:static struct trace_event_call * __used __section(_ftrace_events) \
prev parent reply other threads:[~2020-02-19 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 2:03 Joe Perches
2020-02-19 2:03 ` [RFC PATCH 1/2] trace: Move " Joe Perches
2020-02-19 2:03 ` [RFC PATCH 2/2] trace_events/trace_export: Use __section Joe Perches
2020-02-19 2:53 ` [RFC PATCH 0/2] trace: Move trace data to new section _ftrace_data Steven Rostedt
2020-02-19 3:09 ` Joe Perches
2020-02-19 3:26 ` Steven Rostedt
2020-02-19 3:33 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658fe8a43c01360813d11087ea974b12c02bb6b4.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®