From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] trace: Move trace data to new section _ftrace_data
Date: Tue, 18 Feb 2020 19:09:10 -0800 [thread overview]
Message-ID: <899e4e41c4cf5c62a4fbce0923e5796141ef46f0.camel@perches.com> (raw)
In-Reply-To: <20200218215328.16744447@gandalf.local.home>
On Tue, 2020-02-18 at 21:53 -0500, Steven Rostedt wrote:
> On Tue, 18 Feb 2020 18:03:16 -0800
> Joe Perches <joe@perches.com> wrote:
>
> > Move the trace data to a separate section to make it easier to
> > examine the amount of actual data in an object file.
>
> Not that I'm against this patch set, but can you elaborate more on
> "make it easier to examine the amount of actual data in an object file".
size -A <object> would now show each section of an
object file separating normal data from trace data.
It makes it easier to identify data that could be const like
https://lore.kernel.org/lkml/60559197a1af9e0af7f329cc3427989e5756846f.camel@perches.com/
> Also, don't use "_ftrace" as the section name. "ftrace" should be
> reserved for the function hook part of tracing, which trace events do
> not apply to. "_trace_event_data" would be more appropriate.
I don't care about the section name at all.
I used that name for consistency with _ftrace_event
in the same file.
Perhaps the _ftrace_event section
name could be renamed to something
intelligible too.
next prev parent reply other threads:[~2020-02-19 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 2:03 Joe Perches
2020-02-19 2:03 ` [RFC PATCH 1/2] trace: Move " Joe Perches
2020-02-19 2:03 ` [RFC PATCH 2/2] trace_events/trace_export: Use __section Joe Perches
2020-02-19 2:53 ` [RFC PATCH 0/2] trace: Move trace data to new section _ftrace_data Steven Rostedt
2020-02-19 3:09 ` Joe Perches [this message]
2020-02-19 3:26 ` Steven Rostedt
2020-02-19 3:33 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=899e4e41c4cf5c62a4fbce0923e5796141ef46f0.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome