* [PATCH][V2] net: hns3: remove redundant initialization of pointer 'client'
@ 2020-02-24 19:20 Colin King
2020-02-24 19:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-02-24 19:20 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, David S . Miller, Huazhong Tan, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer 'client' is being initialized with a value that is never
read, it is being updated later on. The initialization is redundant
and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: use reverse christmas tree ordering of local variables
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 51399dbed77a..89d352385260 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -9076,8 +9076,8 @@ static int hclge_init_nic_client_instance(struct hnae3_ae_dev *ae_dev,
static int hclge_init_roce_client_instance(struct hnae3_ae_dev *ae_dev,
struct hclge_vport *vport)
{
- struct hnae3_client *client = vport->roce.client;
struct hclge_dev *hdev = ae_dev->priv;
+ struct hnae3_client *client;
int rst_cnt;
int ret;
--
2.25.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH][V2] net: hns3: remove redundant initialization of pointer 'client'
2020-02-24 19:20 [PATCH][V2] net: hns3: remove redundant initialization of pointer 'client' Colin King
@ 2020-02-24 19:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-24 19:21 UTC (permalink / raw)
To: colin.king
Cc: yisen.zhuang, salil.mehta, tanhuazhong, netdev, kernel-janitors,
linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Mon, 24 Feb 2020 19:20:22 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer 'client' is being initialized with a value that is never
> read, it is being updated later on. The initialization is redundant
> and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: use reverse christmas tree ordering of local variables
Applied to net-next, thanks Colin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-24 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 19:20 [PATCH][V2] net: hns3: remove redundant initialization of pointer 'client' Colin King
2020-02-24 19:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®