* [PATCH] power: supply: axp288_fuel_gauge: Add the Meegopad T02 to the blacklist.
@ 2020-04-06 14:05 rafirafi
2020-04-06 15:44 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: rafirafi @ 2020-04-06 14:05 UTC (permalink / raw)
Cc: rafirafi.at, Sebastian Reichel, Chen-Yu Tsai, Hans de Goede,
linux-pm, linux-kernel
From: Rafael Gandolfi <rafirafi.at@gmail.com>
The Meegopad T02 is a PC in stick format and doesn't have a battery,
it is reported with a random and constant battery charge but as
discharging to userspace.
Add it to the blacklist to avoid the bogus battery status reporting.
Signed-off-by: Rafael Gandolfi <rafirafi.at@gmail.com>
---
drivers/power/supply/axp288_fuel_gauge.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
index e1bc4e6e6f30..0bc548865a61 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -717,6 +717,12 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
},
},
+ {
+ /* Meegopad T02 */
+ .matches = {
+ DMI_MATCH(DMI_PRODUCT_NAME, "MEEGOPAD T02"),
+ },
+ },
{
/* Meegopad T08 */
.matches = {
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] power: supply: axp288_fuel_gauge: Add the Meegopad T02 to the blacklist.
2020-04-06 14:05 [PATCH] power: supply: axp288_fuel_gauge: Add the Meegopad T02 to the blacklist rafirafi
@ 2020-04-06 15:44 ` Hans de Goede
2020-04-13 23:00 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2020-04-06 15:44 UTC (permalink / raw)
To: rafirafi; +Cc: Sebastian Reichel, Chen-Yu Tsai, linux-pm, linux-kernel
Hi,
On 4/6/20 4:05 PM, rafirafi wrote:
> From: Rafael Gandolfi <rafirafi.at@gmail.com>
>
> The Meegopad T02 is a PC in stick format and doesn't have a battery,
> it is reported with a random and constant battery charge but as
> discharging to userspace.
>
> Add it to the blacklist to avoid the bogus battery status reporting.
>
> Signed-off-by: Rafael Gandolfi <rafirafi.at@gmail.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/power/supply/axp288_fuel_gauge.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index e1bc4e6e6f30..0bc548865a61 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -717,6 +717,12 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
> },
> },
> + {
> + /* Meegopad T02 */
> + .matches = {
> + DMI_MATCH(DMI_PRODUCT_NAME, "MEEGOPAD T02"),
> + },
> + },
> {
> /* Meegopad T08 */
> .matches = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] power: supply: axp288_fuel_gauge: Add the Meegopad T02 to the blacklist.
2020-04-06 15:44 ` Hans de Goede
@ 2020-04-13 23:00 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2020-04-13 23:00 UTC (permalink / raw)
To: Hans de Goede; +Cc: rafirafi, Chen-Yu Tsai, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
Hi,
On Mon, Apr 06, 2020 at 05:44:04PM +0200, Hans de Goede wrote:
> Hi,
>
> On 4/6/20 4:05 PM, rafirafi wrote:
> > From: Rafael Gandolfi <rafirafi.at@gmail.com>
> >
> > The Meegopad T02 is a PC in stick format and doesn't have a battery,
> > it is reported with a random and constant battery charge but as
> > discharging to userspace.
> >
> > Add it to the blacklist to avoid the bogus battery status reporting.
> >
> > Signed-off-by: Rafael Gandolfi <rafirafi.at@gmail.com>
>
> Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Thanks, queued.
-- Sebastian
> > ---
> > drivers/power/supply/axp288_fuel_gauge.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> > index e1bc4e6e6f30..0bc548865a61 100644
> > --- a/drivers/power/supply/axp288_fuel_gauge.c
> > +++ b/drivers/power/supply/axp288_fuel_gauge.c
> > @@ -717,6 +717,12 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
> > },
> > },
> > + {
> > + /* Meegopad T02 */
> > + .matches = {
> > + DMI_MATCH(DMI_PRODUCT_NAME, "MEEGOPAD T02"),
> > + },
> > + },
> > {
> > /* Meegopad T08 */
> > .matches = {
> >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-13 23:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 14:05 [PATCH] power: supply: axp288_fuel_gauge: Add the Meegopad T02 to the blacklist rafirafi
2020-04-06 15:44 ` Hans de Goede
2020-04-13 23:00 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®