[PATCH] x86/kvm: Remove defunct KVM_DEBUG_FS Kconfig

[PATCH] x86/kvm: Remove defunct KVM_DEBUG_FS Kconfig

[Sean Christopherson]

Remove KVM_DEBUG_FS, which can easily be misconstrued as controlling
KVM-as-a-host.  The sole user of CONFIG_KVM_DEBUG_FS was removed by
commit cfd8983f03c7b ("x86, locking/spinlocks: Remove ticket (spin)lock
implementation").

Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
 arch/x86/Kconfig      | 8 --------
 arch/x86/kernel/kvm.c | 1 -
 2 files changed, 9 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 1197b5596d5ad..0ccf4e76acfe8 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -818,14 +818,6 @@ config PVH
 	  This option enables the PVH entry point for guest virtual machines
 	  as specified in the x86/HVM direct boot ABI.
 
-config KVM_DEBUG_FS
-	bool "Enable debug information for KVM Guests in debugfs"
-	depends on KVM_GUEST && DEBUG_FS
-	---help---
-	  This option enables collection of various statistics for KVM guest.
-	  Statistics are displayed in debugfs filesystem. Enabling this option
-	  may incur significant overhead.
-
 config PARAVIRT_TIME_ACCOUNTING
 	bool "Paravirtual steal time accounting"
 	depends on PARAVIRT
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 6efe0410fb728..89ba09228eaf5 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -21,7 +21,6 @@
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/kprobes.h>
-#include <linux/debugfs.h>
 #include <linux/nmi.h>
 #include <linux/swait.h>
 #include <asm/timer.h>
-- 
2.26.0

Re: [PATCH] x86/kvm: Remove defunct KVM_DEBUG_FS Kconfig

[Paolo Bonzini]

On 28/05/20 05:11, Sean Christopherson wrote:
> Remove KVM_DEBUG_FS, which can easily be misconstrued as controlling
> KVM-as-a-host.  The sole user of CONFIG_KVM_DEBUG_FS was removed by
> commit cfd8983f03c7b ("x86, locking/spinlocks: Remove ticket (spin)lock
> implementation").
> 
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
>  arch/x86/Kconfig      | 8 --------
>  arch/x86/kernel/kvm.c | 1 -
>  2 files changed, 9 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 1197b5596d5ad..0ccf4e76acfe8 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -818,14 +818,6 @@ config PVH
>  	  This option enables the PVH entry point for guest virtual machines
>  	  as specified in the x86/HVM direct boot ABI.
>  
> -config KVM_DEBUG_FS
> -	bool "Enable debug information for KVM Guests in debugfs"
> -	depends on KVM_GUEST && DEBUG_FS
> -	---help---
> -	  This option enables collection of various statistics for KVM guest.
> -	  Statistics are displayed in debugfs filesystem. Enabling this option
> -	  may incur significant overhead.
> -
>  config PARAVIRT_TIME_ACCOUNTING
>  	bool "Paravirtual steal time accounting"
>  	depends on PARAVIRT
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index 6efe0410fb728..89ba09228eaf5 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -21,7 +21,6 @@
>  #include <linux/sched.h>
>  #include <linux/slab.h>
>  #include <linux/kprobes.h>
> -#include <linux/debugfs.h>
>  #include <linux/nmi.h>
>  #include <linux/swait.h>
>  #include <asm/timer.h>
> 

Queued, thanks.

Paolo