* [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq
@ 2020-05-28 15:04 Colin King
2020-05-29 7:26 ` oulijun
2020-05-29 18:20 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-05-28 15:04 UTC (permalink / raw)
To: Lijun Ou, Wei Hu, Weihang Li, Doug Ledford, Jason Gunthorpe, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer raq is being assigned twice. Fix this by removing
one of the redundant assignments.
Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
Addressses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
index 8ff6b922b4d7..d02207cd30df 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
@@ -1146,7 +1146,7 @@ static void hns_roce_db_free(struct hns_roce_dev *hr_dev)
static int hns_roce_raq_init(struct hns_roce_dev *hr_dev)
{
struct hns_roce_v1_priv *priv = hr_dev->priv;
- struct hns_roce_raq_table *raq = raq = &priv->raq_table;
+ struct hns_roce_raq_table *raq = &priv->raq_table;
struct device *dev = &hr_dev->pdev->dev;
int raq_shift = 0;
dma_addr_t addr;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq
2020-05-28 15:04 [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq Colin King
@ 2020-05-29 7:26 ` oulijun
2020-05-29 18:20 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: oulijun @ 2020-05-29 7:26 UTC (permalink / raw)
To: Colin King, Wei Hu, Weihang Li, Doug Ledford, Jason Gunthorpe,
linux-rdma
Cc: kernel-janitors, linux-kernel
在 2020/5/28 23:04, Colin King 写道:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
>
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index 8ff6b922b4d7..d02207cd30df 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -1146,7 +1146,7 @@ static void hns_roce_db_free(struct hns_roce_dev *hr_dev)
> static int hns_roce_raq_init(struct hns_roce_dev *hr_dev)
> {
> struct hns_roce_v1_priv *priv = hr_dev->priv;
> - struct hns_roce_raq_table *raq = raq = &priv->raq_table;
> + struct hns_roce_raq_table *raq = &priv->raq_table;
> struct device *dev = &hr_dev->pdev->dev;
> int raq_shift = 0;
> dma_addr_t addr;
>
thanks
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq
2020-05-28 15:04 [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq Colin King
2020-05-29 7:26 ` oulijun
@ 2020-05-29 18:20 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-05-29 18:20 UTC (permalink / raw)
To: Colin King
Cc: Lijun Ou, Wei Hu, Weihang Li, Doug Ledford, linux-rdma,
kernel-janitors, linux-kernel
On Thu, May 28, 2020 at 04:04:27PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
>
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next
Thanks,
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-29 18:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 15:04 [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq Colin King
2020-05-29 7:26 ` oulijun
2020-05-29 18:20 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome