From: Michal Kubecek <mkubecek@suse.cz>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
"John W. Linville" <linville@tuxdriver.com>,
David Jander <david@protonic.nl>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
mkl@pengutronix.de, Marek Vasut <marex@denx.de>,
Christian Herber <christian.herber@nxp.com>,
Amit Cohen <amitc@mellanox.com>,
Petr Machata <petrm@mellanox.com>
Subject: Re: [PATCH v2 3/3] netlink: add LINKSTATE SQI support
Date: Sun, 7 Jun 2020 22:24:52 +0200 [thread overview]
Message-ID: <20200607202452.md4nnp47cfjetylp@lion.mk-sys.cz> (raw)
In-Reply-To: <20200528115414.11516-4-o.rempel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1864 bytes --]
On Thu, May 28, 2020 at 01:54:14PM +0200, Oleksij Rempel wrote:
> Some PHYs provide Signal Quality Index (SQI) if the link is in active
> state. This information can help to diagnose cable and system design
> related issues.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
> ---
> netlink/desc-ethtool.c | 2 ++
> netlink/settings.c | 16 ++++++++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/netlink/desc-ethtool.c b/netlink/desc-ethtool.c
> index b0a793c..8f4c36b 100644
> --- a/netlink/desc-ethtool.c
> +++ b/netlink/desc-ethtool.c
> @@ -93,6 +93,8 @@ static const struct pretty_nla_desc __linkstate_desc[] = {
> NLATTR_DESC_INVALID(ETHTOOL_A_LINKSTATE_UNSPEC),
> NLATTR_DESC_NESTED(ETHTOOL_A_LINKSTATE_HEADER, header),
> NLATTR_DESC_BOOL(ETHTOOL_A_LINKSTATE_LINK),
> + NLATTR_DESC_U32(ETHTOOL_A_LINKSTATE_SQI),
> + NLATTR_DESC_U32(ETHTOOL_A_LINKSTATE_SQI_MAX),
> };
>
> static const struct pretty_nla_desc __debug_desc[] = {
> diff --git a/netlink/settings.c b/netlink/settings.c
> index 851de15..cd4b9a7 100644
> --- a/netlink/settings.c
> +++ b/netlink/settings.c
> @@ -638,6 +638,22 @@ int linkstate_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> printf("\tLink detected: %s\n", val ? "yes" : "no");
> }
>
> + if (tb[ETHTOOL_A_LINKSTATE_SQI]) {
> + uint32_t val = mnl_attr_get_u32(tb[ETHTOOL_A_LINKSTATE_SQI]);
> +
> + print_banner(nlctx);
> + printf("\tSQI: %u", val);
> +
> + if (tb[ETHTOOL_A_LINKSTATE_SQI_MAX]) {
> + uint32_t max;
> +
> + max = mnl_attr_get_u32(tb[ETHTOOL_A_LINKSTATE_SQI_MAX]);
> + printf("/%u\n", max);
> + } else {
> + printf("\n");
> + }
> + }
> +
> return MNL_CB_OK;
> }
>
> --
> 2.26.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-06-07 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 11:54 [PATCH v2 0/3] Add support for SQI and master-slave Oleksij Rempel
2020-05-28 11:54 ` [PATCH v2 1/3] update UAPI header copies Oleksij Rempel
2020-05-28 11:54 ` [PATCH v2 2/3] netlink: add master/slave configuration support Oleksij Rempel
2020-06-07 20:39 ` Michal Kubecek
2020-05-28 11:54 ` [PATCH v2 3/3] netlink: add LINKSTATE SQI support Oleksij Rempel
2020-06-07 20:24 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200607202452.md4nnp47cfjetylp@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=amitc@mellanox.com \
--cc=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linville@tuxdriver.com \
--cc=marex@denx.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®