* drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
@ 2020-06-12 5:28 kernel test robot
2020-06-12 7:48 ` Marc Kleine-Budde
0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2020-06-12 5:28 UTC (permalink / raw)
To: Henning Colliander
Cc: kbuild-all, linux-kernel, Marc Kleine-Budde, Jimmy Assarsson,
Christer Beskow
[-- Attachment #1: Type: text/plain, Size: 8190 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b791d1bdf9212d944d749a5c7ff6febdba241771
commit: 26ad340e582d3d5958ed8456a1911d79cfb567b4 can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices
date: 11 months ago
config: m68k-randconfig-s032-20200612 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-250-g42323db3-dirty
git checkout 26ad340e582d3d5958ed8456a1911d79cfb567b4
# save the attached .config to linux build tree
make W=1 C=1 ARCH=m68k CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
drivers/net/can/kvaser_pciefd.c:805:17: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
vim +801 drivers/net/can/kvaser_pciefd.c
764
765 static netdev_tx_t kvaser_pciefd_start_xmit(struct sk_buff *skb,
766 struct net_device *netdev)
767 {
768 struct kvaser_pciefd_can *can = netdev_priv(netdev);
769 unsigned long irq_flags;
770 struct kvaser_pciefd_tx_packet packet;
771 int nwords;
772 u8 count;
773
774 if (can_dropped_invalid_skb(netdev, skb))
775 return NETDEV_TX_OK;
776
777 nwords = kvaser_pciefd_prepare_tx_packet(&packet, can, skb);
778
779 spin_lock_irqsave(&can->echo_lock, irq_flags);
780
781 /* Prepare and save echo skb in internal slot */
782 can_put_echo_skb(skb, netdev, can->echo_idx);
783
784 /* Move echo index to the next slot */
785 can->echo_idx = (can->echo_idx + 1) % can->can.echo_skb_max;
786
787 /* Write header to fifo */
788 iowrite32(packet.header[0],
789 can->reg_base + KVASER_PCIEFD_KCAN_FIFO_REG);
790 iowrite32(packet.header[1],
791 can->reg_base + KVASER_PCIEFD_KCAN_FIFO_REG);
792
793 if (nwords) {
794 u32 data_last = ((u32 *)packet.data)[nwords - 1];
795
796 /* Write data to fifo, except last word */
797 iowrite32_rep(can->reg_base +
798 KVASER_PCIEFD_KCAN_FIFO_REG, packet.data,
799 nwords - 1);
800 /* Write last word to end of fifo */
> 801 __raw_writel(data_last, can->reg_base +
802 KVASER_PCIEFD_KCAN_FIFO_LAST_REG);
803 } else {
804 /* Complete write to fifo */
805 __raw_writel(0, can->reg_base +
806 KVASER_PCIEFD_KCAN_FIFO_LAST_REG);
807 }
808
809 count = ioread32(can->reg_base + KVASER_PCIEFD_KCAN_TX_NPACKETS_REG);
810 /* No room for a new message, stop the queue until at least one
811 * successful transmit
812 */
813 if (count >= KVASER_PCIEFD_CAN_TX_MAX_COUNT ||
814 can->can.echo_skb[can->echo_idx])
815 netif_stop_queue(netdev);
816
817 spin_unlock_irqrestore(&can->echo_lock, irq_flags);
818
819 return NETDEV_TX_OK;
820 }
821
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26069 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
2020-06-12 5:28 drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression kernel test robot
@ 2020-06-12 7:48 ` Marc Kleine-Budde
2020-06-12 15:33 ` Greg Ungerer
0 siblings, 1 reply; 6+ messages in thread
From: Marc Kleine-Budde @ 2020-06-12 7:48 UTC (permalink / raw)
To: kernel test robot, Henning Colliander, Greg Ungerer
Cc: kbuild-all, linux-kernel, Jimmy Assarsson, Christer Beskow
Hello Greg,
the k-build robot found this sparse problem, triggered by building a CAN driver
for m68k. Is this a problem in our CAN driver or in the m68k headers?
Marc
On 6/12/20 7:28 AM, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: b791d1bdf9212d944d749a5c7ff6febdba241771
> commit: 26ad340e582d3d5958ed8456a1911d79cfb567b4 can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices
> date: 11 months ago
> config: m68k-randconfig-s032-20200612 (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.1-250-g42323db3-dirty
> git checkout 26ad340e582d3d5958ed8456a1911d79cfb567b4
> # save the attached .config to linux build tree
> make W=1 C=1 ARCH=m68k CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
> drivers/net/can/kvaser_pciefd.c:805:17: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>
> vim +801 drivers/net/can/kvaser_pciefd.c
>
> 764
> 765 static netdev_tx_t kvaser_pciefd_start_xmit(struct sk_buff *skb,
> 766 struct net_device *netdev)
> 767 {
> 768 struct kvaser_pciefd_can *can = netdev_priv(netdev);
> 769 unsigned long irq_flags;
> 770 struct kvaser_pciefd_tx_packet packet;
> 771 int nwords;
> 772 u8 count;
> 773
> 774 if (can_dropped_invalid_skb(netdev, skb))
> 775 return NETDEV_TX_OK;
> 776
> 777 nwords = kvaser_pciefd_prepare_tx_packet(&packet, can, skb);
> 778
> 779 spin_lock_irqsave(&can->echo_lock, irq_flags);
> 780
> 781 /* Prepare and save echo skb in internal slot */
> 782 can_put_echo_skb(skb, netdev, can->echo_idx);
> 783
> 784 /* Move echo index to the next slot */
> 785 can->echo_idx = (can->echo_idx + 1) % can->can.echo_skb_max;
> 786
> 787 /* Write header to fifo */
> 788 iowrite32(packet.header[0],
> 789 can->reg_base + KVASER_PCIEFD_KCAN_FIFO_REG);
> 790 iowrite32(packet.header[1],
> 791 can->reg_base + KVASER_PCIEFD_KCAN_FIFO_REG);
> 792
> 793 if (nwords) {
> 794 u32 data_last = ((u32 *)packet.data)[nwords - 1];
> 795
> 796 /* Write data to fifo, except last word */
> 797 iowrite32_rep(can->reg_base +
> 798 KVASER_PCIEFD_KCAN_FIFO_REG, packet.data,
> 799 nwords - 1);
> 800 /* Write last word to end of fifo */
> > 801 __raw_writel(data_last, can->reg_base +
> 802 KVASER_PCIEFD_KCAN_FIFO_LAST_REG);
> 803 } else {
> 804 /* Complete write to fifo */
> 805 __raw_writel(0, can->reg_base +
> 806 KVASER_PCIEFD_KCAN_FIFO_LAST_REG);
> 807 }
> 808
> 809 count = ioread32(can->reg_base + KVASER_PCIEFD_KCAN_TX_NPACKETS_REG);
> 810 /* No room for a new message, stop the queue until at least one
> 811 * successful transmit
> 812 */
> 813 if (count >= KVASER_PCIEFD_CAN_TX_MAX_COUNT ||
> 814 can->can.echo_skb[can->echo_idx])
> 815 netif_stop_queue(netdev);
> 816
> 817 spin_unlock_irqrestore(&can->echo_lock, irq_flags);
> 818
> 819 return NETDEV_TX_OK;
> 820 }
> 821
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
2020-06-12 7:48 ` Marc Kleine-Budde
@ 2020-06-12 15:33 ` Greg Ungerer
2020-06-12 16:35 ` Luc Van Oostenryck
0 siblings, 1 reply; 6+ messages in thread
From: Greg Ungerer @ 2020-06-12 15:33 UTC (permalink / raw)
To: Marc Kleine-Budde, kernel test robot, Henning Colliander
Cc: kbuild-all, linux-kernel, Jimmy Assarsson, Christer Beskow
Hi Marc,
On 12/6/20 5:48 pm, Marc Kleine-Budde wrote:
> the k-build robot found this sparse problem, triggered by building a CAN driver
> for m68k. Is this a problem in our CAN driver or in the m68k headers?
I suspect a problem with the m68k (specifically non-mmu) headers.
> On 6/12/20 7:28 AM, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: b791d1bdf9212d944d749a5c7ff6febdba241771
>> commit: 26ad340e582d3d5958ed8456a1911d79cfb567b4 can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices
>> date: 11 months ago
>> config: m68k-randconfig-s032-20200612 (attached as .config)
>> compiler: m68k-linux-gcc (GCC) 9.3.0
>> reproduce:
>> # apt-get install sparse
>> # sparse version: v0.6.1-250-g42323db3-dirty
>> git checkout 26ad340e582d3d5958ed8456a1911d79cfb567b4
>> # save the attached .config to linux build tree
>> make W=1 C=1 ARCH=m68k CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>>
>> sparse warnings: (new ones prefixed by >>)
>>
>>>> drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
>> drivers/net/can/kvaser_pciefd.c:805:17: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
I think this one is due to not forcing the volatile cast in __raw_write().
So this change will fix that:
diff --git a/arch/m68k/include/asm/io_no.h b/arch/m68k/include/asm/io_no.h
index 0498192e1d98..1bc739f1f1ad 100644
--- a/arch/m68k/include/asm/io_no.h
+++ b/arch/m68k/include/asm/io_no.h
@@ -14,15 +14,15 @@
* that behavior here first before we include asm-generic/io.h.
*/
#define __raw_readb(addr) \
- ({ unsigned char __v = (*(volatile unsigned char *) (addr)); __v; })
+ ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; })
#define __raw_readw(addr) \
- ({ unsigned short __v = (*(volatile unsigned short *) (addr)); __v; })
+ ({ u16 __v = (*(__force volatile u16 *) (addr)); __v; })
#define __raw_readl(addr) \
- ({ unsigned int __v = (*(volatile unsigned int *) (addr)); __v; })
+ ({ u32 __v = (*(__force volatile u32 *) (addr)); __v; })
-#define __raw_writeb(b, addr) (void)((*(volatile unsigned char *) (addr)) = (b))
-#define __raw_writew(b, addr) (void)((*(volatile unsigned short *) (addr)) = (b))
-#define __raw_writel(b, addr) (void)((*(volatile unsigned int *) (addr)) = (b))
+#define __raw_writeb(b, addr) (void)((*(__force volatile u8 *) (addr)) = (b))
+#define __raw_writew(b, addr) (void)((*(__force volatile u16 *) (addr)) = (b))
+#define __raw_writel(b, addr) (void)((*(__force volatile u32 *) (addr)) = (b))
#if defined(CONFIG_COLDFIRE)
/*
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
This one I am not sure about yet.
Still investigating.
Regards
Greg
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:77:24: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast removes address space '<asn:2>' of expression
>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>>
>> vim +801 drivers/net/can/kvaser_pciefd.c
>>
>> 764
>> 765 static netdev_tx_t kvaser_pciefd_start_xmit(struct sk_buff *skb,
>> 766 struct net_device *netdev)
>> 767 {
>> 768 struct kvaser_pciefd_can *can = netdev_priv(netdev);
>> 769 unsigned long irq_flags;
>> 770 struct kvaser_pciefd_tx_packet packet;
>> 771 int nwords;
>> 772 u8 count;
>> 773
>> 774 if (can_dropped_invalid_skb(netdev, skb))
>> 775 return NETDEV_TX_OK;
>> 776
>> 777 nwords = kvaser_pciefd_prepare_tx_packet(&packet, can, skb);
>> 778
>> 779 spin_lock_irqsave(&can->echo_lock, irq_flags);
>> 780
>> 781 /* Prepare and save echo skb in internal slot */
>> 782 can_put_echo_skb(skb, netdev, can->echo_idx);
>> 783
>> 784 /* Move echo index to the next slot */
>> 785 can->echo_idx = (can->echo_idx + 1) % can->can.echo_skb_max;
>> 786
>> 787 /* Write header to fifo */
>> 788 iowrite32(packet.header[0],
>> 789 can->reg_base + KVASER_PCIEFD_KCAN_FIFO_REG);
>> 790 iowrite32(packet.header[1],
>> 791 can->reg_base + KVASER_PCIEFD_KCAN_FIFO_REG);
>> 792
>> 793 if (nwords) {
>> 794 u32 data_last = ((u32 *)packet.data)[nwords - 1];
>> 795
>> 796 /* Write data to fifo, except last word */
>> 797 iowrite32_rep(can->reg_base +
>> 798 KVASER_PCIEFD_KCAN_FIFO_REG, packet.data,
>> 799 nwords - 1);
>> 800 /* Write last word to end of fifo */
>> > 801 __raw_writel(data_last, can->reg_base +
>> 802 KVASER_PCIEFD_KCAN_FIFO_LAST_REG);
>> 803 } else {
>> 804 /* Complete write to fifo */
>> 805 __raw_writel(0, can->reg_base +
>> 806 KVASER_PCIEFD_KCAN_FIFO_LAST_REG);
>> 807 }
>> 808
>> 809 count = ioread32(can->reg_base + KVASER_PCIEFD_KCAN_TX_NPACKETS_REG);
>> 810 /* No room for a new message, stop the queue until at least one
>> 811 * successful transmit
>> 812 */
>> 813 if (count >= KVASER_PCIEFD_CAN_TX_MAX_COUNT ||
>> 814 can->can.echo_skb[can->echo_idx])
>> 815 netif_stop_queue(netdev);
>> 816
>> 817 spin_unlock_irqrestore(&can->echo_lock, irq_flags);
>> 818
>> 819 return NETDEV_TX_OK;
>> 820 }
>> 821
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
2020-06-12 15:33 ` Greg Ungerer
@ 2020-06-12 16:35 ` Luc Van Oostenryck
2020-06-13 2:19 ` Greg Ungerer
2020-06-15 7:07 ` Greg Ungerer
0 siblings, 2 replies; 6+ messages in thread
From: Luc Van Oostenryck @ 2020-06-12 16:35 UTC (permalink / raw)
To: Greg Ungerer
Cc: Marc Kleine-Budde, kernel test robot, Henning Colliander,
kbuild-all, linux-kernel, Jimmy Assarsson, Christer Beskow
On Sat, Jun 13, 2020 at 01:33:16AM +1000, Greg Ungerer wrote:
> Hi Marc,
>
> On 12/6/20 5:48 pm, Marc Kleine-Budde wrote:
> > the k-build robot found this sparse problem, triggered by building a CAN driver
> > for m68k. Is this a problem in our CAN driver or in the m68k headers?
>
> I suspect a problem with the m68k (specifically non-mmu) headers.
Indeed.
> I think this one is due to not forcing the volatile cast in __raw_write().
> So this change will fix that:
>
> diff --git a/arch/m68k/include/asm/io_no.h b/arch/m68k/include/asm/io_no.h
> index 0498192e1d98..1bc739f1f1ad 100644
> --- a/arch/m68k/include/asm/io_no.h
> +++ b/arch/m68k/include/asm/io_no.h
> @@ -14,15 +14,15 @@
> * that behavior here first before we include asm-generic/io.h.
> */
> #define __raw_readb(addr) \
> - ({ unsigned char __v = (*(volatile unsigned char *) (addr)); __v; })
> + ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; })
> #define __raw_readw(addr) \
> - ({ unsigned short __v = (*(volatile unsigned short *) (addr)); __v; })
> + ({ u16 __v = (*(__force volatile u16 *) (addr)); __v; })
> #define __raw_readl(addr) \
> - ({ unsigned int __v = (*(volatile unsigned int *) (addr)); __v; })
> + ({ u32 __v = (*(__force volatile u32 *) (addr)); __v; })
> -#define __raw_writeb(b, addr) (void)((*(volatile unsigned char *) (addr)) = (b))
> -#define __raw_writew(b, addr) (void)((*(volatile unsigned short *) (addr)) = (b))
> -#define __raw_writel(b, addr) (void)((*(volatile unsigned int *) (addr)) = (b))
> +#define __raw_writeb(b, addr) (void)((*(__force volatile u8 *) (addr)) = (b))
> +#define __raw_writew(b, addr) (void)((*(__force volatile u16 *) (addr)) = (b))
> +#define __raw_writel(b, addr) (void)((*(__force volatile u32 *) (addr)) = (b))
Look good to me but isn't easier to leave them undefined and include
asm-generic/io.h?
> > > arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>
> This one I am not sure about yet.
> Still investigating.
swab32(__raw_readl(addr)) ?
Keeping __le32_to_cpu() will only force you to use ugly casts for no benefits
and the comment above explain clearly the situation about the endianness.
Best regards,
-- Luc
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
2020-06-12 16:35 ` Luc Van Oostenryck
@ 2020-06-13 2:19 ` Greg Ungerer
2020-06-15 7:07 ` Greg Ungerer
1 sibling, 0 replies; 6+ messages in thread
From: Greg Ungerer @ 2020-06-13 2:19 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: Marc Kleine-Budde, kernel test robot, Henning Colliander,
kbuild-all, linux-kernel, Jimmy Assarsson, Christer Beskow
On 13/6/20 2:35 am, Luc Van Oostenryck wrote:
> On Sat, Jun 13, 2020 at 01:33:16AM +1000, Greg Ungerer wrote:
>> On 12/6/20 5:48 pm, Marc Kleine-Budde wrote:
>> I think this one is due to not forcing the volatile cast in __raw_write().
>> So this change will fix that:
>>
>> diff --git a/arch/m68k/include/asm/io_no.h b/arch/m68k/include/asm/io_no.h
>> index 0498192e1d98..1bc739f1f1ad 100644
>> --- a/arch/m68k/include/asm/io_no.h
>> +++ b/arch/m68k/include/asm/io_no.h
>> @@ -14,15 +14,15 @@
>> * that behavior here first before we include asm-generic/io.h.
>> */
>> #define __raw_readb(addr) \
>> - ({ unsigned char __v = (*(volatile unsigned char *) (addr)); __v; })
>> + ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; })
>> #define __raw_readw(addr) \
>> - ({ unsigned short __v = (*(volatile unsigned short *) (addr)); __v; })
>> + ({ u16 __v = (*(__force volatile u16 *) (addr)); __v; })
>> #define __raw_readl(addr) \
>> - ({ unsigned int __v = (*(volatile unsigned int *) (addr)); __v; })
>> + ({ u32 __v = (*(__force volatile u32 *) (addr)); __v; })
>> -#define __raw_writeb(b, addr) (void)((*(volatile unsigned char *) (addr)) = (b))
>> -#define __raw_writew(b, addr) (void)((*(volatile unsigned short *) (addr)) = (b))
>> -#define __raw_writel(b, addr) (void)((*(volatile unsigned int *) (addr)) = (b))
>> +#define __raw_writeb(b, addr) (void)((*(__force volatile u8 *) (addr)) = (b))
>> +#define __raw_writew(b, addr) (void)((*(__force volatile u16 *) (addr)) = (b))
>> +#define __raw_writel(b, addr) (void)((*(__force volatile u32 *) (addr)) = (b))
>
> Look good to me but isn't easier to leave them undefined and include
> asm-generic/io.h?
Not so simple at the moment. Although juggling a few things around within
io_no.h will let you use the asm-generic functions it will now throw up
a _lot_ of warnings in many of the architecture files that pass int constant
addresses to the raw_* functions. That is on my todo list.
Regards
Greg
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression
2020-06-12 16:35 ` Luc Van Oostenryck
2020-06-13 2:19 ` Greg Ungerer
@ 2020-06-15 7:07 ` Greg Ungerer
1 sibling, 0 replies; 6+ messages in thread
From: Greg Ungerer @ 2020-06-15 7:07 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: Marc Kleine-Budde, kernel test robot, Henning Colliander,
kbuild-all, linux-kernel, Jimmy Assarsson, Christer Beskow
On 13/6/20 2:35 am, Luc Van Oostenryck wrote:
> On Sat, Jun 13, 2020 at 01:33:16AM +1000, Greg Ungerer wrote:
>>>> arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32
>>
>> This one I am not sure about yet.
>> Still investigating.
>
> swab32(__raw_readl(addr)) ?
>
> Keeping __le32_to_cpu() will only force you to use ugly casts for no benefits
> and the comment above explain clearly the situation about the endianness.
That is unfortunate, the use of le32_to_cpu() made it very clear
what was going on - for those that don't choose to read comments.
In any case that would seem to be the cleanest solution.
Patch to follow.
Regards
Greg
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-15 7:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 5:28 drivers/net/can/kvaser_pciefd.c:801:17: sparse: sparse: cast removes address space '<asn:2>' of expression kernel test robot
2020-06-12 7:48 ` Marc Kleine-Budde
2020-06-12 15:33 ` Greg Ungerer
2020-06-12 16:35 ` Luc Van Oostenryck
2020-06-13 2:19 ` Greg Ungerer
2020-06-15 7:07 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®