From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: SeongJae Park <sj38.park@gmail.com>
Cc: Joe Perches <joe@perches.com>, SeongJae Park <sjpark@amazon.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, apw@canonical.com,
colin.king@canonical.com, jslaby@suse.cz, pavel@ucw.cz,
SeongJae Park <sjpark@amazon.de>
Subject: Re: checkpatch: support deprecated terms checking
Date: Sun, 26 Jul 2020 22:33:28 +0200 [thread overview]
Message-ID: <20200726203328.GA8321@qmqm.qmqm.pl> (raw)
In-Reply-To: <20200726180748.29924-1-sj38.park@gmail.com>
On Sun, Jul 26, 2020 at 08:07:48PM +0200, SeongJae Park wrote:
> On Sun, 26 Jul 2020 09:42:06 -0700 Joe Perches <joe@perches.com> wrote:
>
> > On Sun, 2020-07-26 at 17:36 +0200, SeongJae Park wrote:
> > > On Sun, 26 Jul 2020 07:50:54 -0700 Joe Perches <joe@perches.com> wrote:
> > []
> > > > I do not want to encourage relatively inexperienced people
> > > > to run checkpatch and submit inappropriate patches.
> > >
> > > Me, neither. But, I think providing more warnings and references is better for
> > > that.
> >
> > Unfortunately, the inexperienced _do_ in fact run
> > checkpatch on files and submit inappropriate patches.
> >
> > It's generally a time sink for the experienced
> > maintainers to reply.
> >
> > > Simply limiting checks could allow people submitting inappropriate patches
> > > intorducing new uses of deprecated terms.
> >
> > Tradeoffs...
> >
> > I expect that patches being reviewed by maintainers
> > are preferred over files being inappropriately changed
> > by the inexperienced.
> >
> > Those inappropriate changes should not be encouraged
> > by tools placed in the hands of the inexperienced.
>
> Right, many things are tradeoff. Seems we arrived in the point, though we
> still have different opinions. To summarize the pros and cons of my patch from
> my perspective:
>
> Pros 1: Handle future terms deprecated with different reasons and coverages.
> Pros 2: Inappropriate patches are avoided if the submitters carefully read the
> warning messages.
> Cons: Careless people could still bother maintainers by not carefully reading
> the message and sending inappropriate patches.
>
> To me, the pros still seems larger than the cons. I would like to also again
> mention that the maintainer who first reported the problem, Michal, told it's
> ok with the explicit messaging. Nonethelss, this is just my opinion.
>
> Attaching the patch addressing your comments for the previous version. The
> changes from the previous version are:
>
> - Make the name of reported terms not too verbose
> - Avoid unnecessary initialization of the reported terms hash
> - Warn multiple deprecated terms in same line
Hi,
Maybe you could split the meaning of --subjective and --strict, and
enable those checks only for --subjective? The test is really hard to do
right: you would have to consider the context and not only mere occurrence
of a word (heh, I even wrote 'blacklisted' here, since it really is about
a night/danger analogy and not political/ethical one).
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2020-07-26 20:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 6:25 [PATCH v4 0/2] Recommend denylist/allowlist instead of blacklist/whitelist SeongJae Park
2020-06-11 6:25 ` [PATCH v4 1/2] checkpatch: support deprecated terms checking SeongJae Park
2020-07-25 13:02 ` Michał Mirosław
2020-07-25 16:36 ` Joe Perches
2020-07-25 17:29 ` Joe Perches
2020-07-25 23:35 ` SeongJae Park
2020-07-26 4:27 ` Joe Perches
2020-07-26 7:18 ` SeongJae Park
2020-07-26 7:29 ` Joe Perches
2020-07-26 7:45 ` SeongJae Park
2020-07-26 14:50 ` Joe Perches
2020-07-26 15:36 ` SeongJae Park
2020-07-26 16:42 ` Joe Perches
2020-07-26 18:07 ` SeongJae Park
2020-07-26 20:33 ` Michał Mirosław [this message]
2020-07-27 6:54 ` SeongJae Park
2020-07-27 20:44 ` Andrew Morton
2020-07-27 20:49 ` Joe Perches
2020-07-28 6:22 ` SeongJae Park
2020-06-11 6:25 ` [PATCH v4 2/2] scripts/deprecated_terms: Recommend denylist/allowlist instead of blacklist/whitelist SeongJae Park
2020-06-11 6:35 ` [PATCH v4 0/2] " Joe Perches
2020-06-11 7:38 ` SeongJae Park
2020-06-11 8:16 ` Jiri Slaby
2020-06-11 8:30 ` SeongJae Park
2020-06-11 8:32 ` Jiri Slaby
2020-06-11 10:43 ` Joe Perches
2020-06-12 6:40 ` SeongJae Park
2020-06-12 7:05 ` Joe Perches
2020-06-12 14:40 ` Michael Ellerman
2020-06-14 21:29 ` Pavel Machek
2020-06-15 4:21 ` Jiri Slaby
2020-06-15 6:12 ` Pavel Machek
2020-06-15 6:46 ` SeongJae Park
2020-06-15 7:00 ` Joe Perches
2020-06-15 7:39 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726203328.GA8321@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=colin.king@canonical.com \
--cc=joe@perches.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®