* [PATCH] media: ov5640: Correct Bit Div register in clock tree diagram
@ 2020-08-03 9:06 Paul Kocialkowski
2020-08-05 12:51 ` Jacopo Mondi
0 siblings, 1 reply; 3+ messages in thread
From: Paul Kocialkowski @ 2020-08-03 9:06 UTC (permalink / raw)
To: linux-media, linux-kernel
Cc: Steve Longerbeam, Mauro Carvalho Chehab, Maxime Ripard,
Hans Verkuil, Paul Kocialkowski
Although the code is correct and doing the right thing, the clock diagram
showed the wrong register for the bit divider, which had me doubting the
understanding of the tree. Fix this to avoid doubts in the future.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/media/i2c/ov5640.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 854031f0b64a..fe08a45b0426 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -751,7 +751,7 @@ static int ov5640_mod_reg(struct ov5640_dev *sensor, u16 reg,
* +->| PLL Root Div | - reg 0x3037, bit 4
* +-+------------+
* | +---------+
- * +->| Bit Div | - reg 0x3035, bits 0-3
+ * +->| Bit Div | - reg 0x3034, bits 0-3
* +-+-------+
* | +-------------+
* +->| SCLK Div | - reg 0x3108, bits 0-1
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: ov5640: Correct Bit Div register in clock tree diagram
2020-08-03 9:06 [PATCH] media: ov5640: Correct Bit Div register in clock tree diagram Paul Kocialkowski
@ 2020-08-05 12:51 ` Jacopo Mondi
2020-08-13 21:51 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Jacopo Mondi @ 2020-08-05 12:51 UTC (permalink / raw)
To: Paul Kocialkowski
Cc: linux-media, linux-kernel, Steve Longerbeam,
Mauro Carvalho Chehab, Maxime Ripard, Hans Verkuil
Hi Paul,
On Mon, Aug 03, 2020 at 11:06:58AM +0200, Paul Kocialkowski wrote:
> Although the code is correct and doing the right thing, the clock diagram
> showed the wrong register for the bit divider, which had me doubting the
> understanding of the tree. Fix this to avoid doubts in the future.
Thanks for spotting this! Correct indeed!
I'm not sure it's worth a fixes tag, but just in case:
Fixes: aa2882481cada ("media: ov5640: Adjust the clock based on the expected rate")
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> drivers/media/i2c/ov5640.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 854031f0b64a..fe08a45b0426 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -751,7 +751,7 @@ static int ov5640_mod_reg(struct ov5640_dev *sensor, u16 reg,
> * +->| PLL Root Div | - reg 0x3037, bit 4
> * +-+------------+
> * | +---------+
> - * +->| Bit Div | - reg 0x3035, bits 0-3
> + * +->| Bit Div | - reg 0x3034, bits 0-3
> * +-+-------+
> * | +-------------+
> * +->| SCLK Div | - reg 0x3108, bits 0-1
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: ov5640: Correct Bit Div register in clock tree diagram
2020-08-05 12:51 ` Jacopo Mondi
@ 2020-08-13 21:51 ` Sakari Ailus
0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2020-08-13 21:51 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Paul Kocialkowski, linux-media, linux-kernel, Steve Longerbeam,
Mauro Carvalho Chehab, Maxime Ripard, Hans Verkuil
On Wed, Aug 05, 2020 at 02:51:13PM +0200, Jacopo Mondi wrote:
> Hi Paul,
>
> On Mon, Aug 03, 2020 at 11:06:58AM +0200, Paul Kocialkowski wrote:
> > Although the code is correct and doing the right thing, the clock diagram
> > showed the wrong register for the bit divider, which had me doubting the
> > understanding of the tree. Fix this to avoid doubts in the future.
>
> Thanks for spotting this! Correct indeed!
>
> I'm not sure it's worth a fixes tag, but just in case:
> Fixes: aa2882481cada ("media: ov5640: Adjust the clock based on the expected rate")
Added that.
>
>
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks, Paul and Jacopo!
--
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-13 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 9:06 [PATCH] media: ov5640: Correct Bit Div register in clock tree diagram Paul Kocialkowski
2020-08-05 12:51 ` Jacopo Mondi
2020-08-13 21:51 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®