From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: robin@protonic.nl, linux@rempel-privat.de, kernel@pengutronix.de,
socketcan@hartkopp.net, mkl@pengutronix.de, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH net 0/4] support multipacket broadcast message
Date: Fri, 7 Aug 2020 15:15:52 +0200 [thread overview]
Message-ID: <20200807131552.4hsuafdubumvh3hl@pengutronix.de> (raw)
In-Reply-To: <24c3daa5-8243-0b80-9f4c-aa5883cb75da@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
On Fri, Aug 07, 2020 at 05:36:38PM +0800, Zhang Changzhong wrote:
> Hi Oleksij,
>
> We have tested this j1939 stack according to SAE J1939-21. It works fine for
> most cases, but when we test multipacket broadcast message function we found
> the receiver can't receive those packets.
>
> You can reproduce on CAN bus or vcan, for vcan case use cangw to connect vcan0
> and vcan1:
> sudo cangw -A -s vcan0 -d vcan1 -e
> sudo cangw -A -s vcan1 -d vcan0 -e
>
> To reproduce it use following commands:
> testj1939 -B -r vcan1:0x90 &
> testj1939 -B -s20 vcan0:0x80 :,0x12300
>
> Besides, candump receives correct packets while testj1939 receives nothing.
Ok, thank you!
i'm able to reproduce it and added following test:
https://github.com/linux-can/can-tests/blob/master/j1939/j1939_ac_1k_bam_local0.sh
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-07 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 3:50 Zhang Changzhong
2020-08-05 3:50 ` [PATCH net 1/4] can: j1939: fix support for " Zhang Changzhong
2020-08-05 3:50 ` [PATCH net 2/4] can: j1939: cancel rxtimer on multipacket broadcast session complete Zhang Changzhong
2020-08-05 3:50 ` [PATCH net 3/4] can: j1939: abort multipacket broadcast session when timeout occurs Zhang Changzhong
2020-08-05 3:50 ` [PATCH net 4/4] can: j1939: add rxtimer for multipacket broadcast session Zhang Changzhong
2020-08-06 16:10 ` [PATCH net 0/4] support multipacket broadcast message Oleksij Rempel
2020-08-07 9:36 ` Zhang Changzhong
2020-08-07 13:15 ` Oleksij Rempel [this message]
2020-08-14 11:01 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807131552.4hsuafdubumvh3hl@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=robin@protonic.nl \
--cc=socketcan@hartkopp.net \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®