* [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options @ 2020-08-09 18:54 Alex Dewar 2020-08-11 14:24 ` David Lechner 0 siblings, 1 reply; 9+ messages in thread From: Alex Dewar @ 2020-08-09 18:54 UTC (permalink / raw) To: Sebastian Reichel, David Lechner, linux-pm, linux-kernel; +Cc: Alex Dewar This battery appears only to be used by a single board (DA850), so it makes sense to add this to the Kconfig file so that users don't build the module unnecessarily. It currently seems to be built for the x86 Arch Linux kernel where it's probably not doing much good. Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> --- drivers/power/supply/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index faf2830aa1527..9f76e2f47ac6d 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -164,7 +164,7 @@ config BATTERY_DS2782 config BATTERY_LEGO_EV3 tristate "LEGO MINDSTORMS EV3 battery" - depends on OF && IIO && GPIOLIB + depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST) help Say Y here to enable support for the LEGO MINDSTORMS EV3 battery. -- 2.28.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options 2020-08-09 18:54 [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options Alex Dewar @ 2020-08-11 14:24 ` David Lechner 2020-08-12 13:37 ` Alex Dewar 0 siblings, 1 reply; 9+ messages in thread From: David Lechner @ 2020-08-11 14:24 UTC (permalink / raw) To: Alex Dewar, Sebastian Reichel, linux-pm, linux-kernel Cc: Sekhar Nori, Bartosz Gołaszewski On 8/9/20 1:54 PM, Alex Dewar wrote: > This battery appears only to be used by a single board (DA850), so it > makes sense to add this to the Kconfig file so that users don't build > the module unnecessarily. It currently seems to be built for the x86 > Arch Linux kernel where it's probably not doing much good. It would probably also make sense to add "default n" since it only applies to one board in the entire arch. BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate defconfig file, so I don't think it would break anything. > > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> > --- > drivers/power/supply/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > index faf2830aa1527..9f76e2f47ac6d 100644 > --- a/drivers/power/supply/Kconfig > +++ b/drivers/power/supply/Kconfig > @@ -164,7 +164,7 @@ config BATTERY_DS2782 > > config BATTERY_LEGO_EV3 > tristate "LEGO MINDSTORMS EV3 battery" > - depends on OF && IIO && GPIOLIB > + depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST) > help > Say Y here to enable support for the LEGO MINDSTORMS EV3 battery. > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options 2020-08-11 14:24 ` David Lechner @ 2020-08-12 13:37 ` Alex Dewar 2020-08-12 15:24 ` David Lechner 0 siblings, 1 reply; 9+ messages in thread From: Alex Dewar @ 2020-08-12 13:37 UTC (permalink / raw) To: David Lechner Cc: Alex Dewar, Sebastian Reichel, linux-pm, linux-kernel, Sekhar Nori, Bartosz Go??aszewski On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote: > On 8/9/20 1:54 PM, Alex Dewar wrote: > > This battery appears only to be used by a single board (DA850), so it > > makes sense to add this to the Kconfig file so that users don't build > > the module unnecessarily. It currently seems to be built for the x86 > > Arch Linux kernel where it's probably not doing much good. > > It would probably also make sense to add "default n" since it only > applies to one board in the entire arch. Ah ok. That makes sense. Would you like me to send a follow-on patch for this? Alex > > BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate > defconfig file, so I don't think it would break anything. > > > > > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> > > --- > > drivers/power/supply/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > > index faf2830aa1527..9f76e2f47ac6d 100644 > > --- a/drivers/power/supply/Kconfig > > +++ b/drivers/power/supply/Kconfig > > @@ -164,7 +164,7 @@ config BATTERY_DS2782 > > config BATTERY_LEGO_EV3 > > tristate "LEGO MINDSTORMS EV3 battery" > > - depends on OF && IIO && GPIOLIB > > + depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST) > > help > > Say Y here to enable support for the LEGO MINDSTORMS EV3 battery. > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options 2020-08-12 13:37 ` Alex Dewar @ 2020-08-12 15:24 ` David Lechner 2020-08-12 19:02 ` Alex Dewar 0 siblings, 1 reply; 9+ messages in thread From: David Lechner @ 2020-08-12 15:24 UTC (permalink / raw) To: Alex Dewar Cc: Sebastian Reichel, linux-pm, linux-kernel, Sekhar Nori, Bartosz Go??aszewski On 8/12/20 8:37 AM, Alex Dewar wrote: > On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote: >> On 8/9/20 1:54 PM, Alex Dewar wrote: >>> This battery appears only to be used by a single board (DA850), so it >>> makes sense to add this to the Kconfig file so that users don't build >>> the module unnecessarily. It currently seems to be built for the x86 >>> Arch Linux kernel where it's probably not doing much good. >> >> It would probably also make sense to add "default n" since it only >> applies to one board in the entire arch. > > Ah ok. That makes sense. Would you like me to send a follow-on patch for > this? You can just send a v2 patch that includes the change below and the additional change. > > Alex > >> >> BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate >> defconfig file, so I don't think it would break anything. >> >>> >>> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> >>> --- >>> drivers/power/supply/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig >>> index faf2830aa1527..9f76e2f47ac6d 100644 >>> --- a/drivers/power/supply/Kconfig >>> +++ b/drivers/power/supply/Kconfig >>> @@ -164,7 +164,7 @@ config BATTERY_DS2782 >>> config BATTERY_LEGO_EV3 >>> tristate "LEGO MINDSTORMS EV3 battery" >>> - depends on OF && IIO && GPIOLIB >>> + depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST) >>> help >>> Say Y here to enable support for the LEGO MINDSTORMS EV3 battery. >>> >> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options 2020-08-12 15:24 ` David Lechner @ 2020-08-12 19:02 ` Alex Dewar 2020-08-12 19:12 ` David Lechner 0 siblings, 1 reply; 9+ messages in thread From: Alex Dewar @ 2020-08-12 19:02 UTC (permalink / raw) To: David Lechner Cc: Alex Dewar, Sebastian Reichel, linux-pm, linux-kernel, Sekhar Nori, Bartosz Go??aszewski On Wed, Aug 12, 2020 at 10:24:30AM -0500, David Lechner wrote: > On 8/12/20 8:37 AM, Alex Dewar wrote: > > On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote: > > > On 8/9/20 1:54 PM, Alex Dewar wrote: > > > > This battery appears only to be used by a single board (DA850), so it > > > > makes sense to add this to the Kconfig file so that users don't build > > > > the module unnecessarily. It currently seems to be built for the x86 > > > > Arch Linux kernel where it's probably not doing much good. > > > > > > It would probably also make sense to add "default n" since it only > > > applies to one board in the entire arch. > > > > Ah ok. That makes sense. Would you like me to send a follow-on patch for > > this? > > You can just send a v2 patch that includes the change below and the > additional change. I've just had a look at the documentation[1] and it seems that as there's no "default y" there it'll default to n anyway. Have I got that right? [1] https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-attributes > > > > > Alex > > > > > > > > BATTERY_LEGO_EV3 is already explicitly set to "m" in the appropriate > > > defconfig file, so I don't think it would break anything. > > > > > > > > > > > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> > > > > --- > > > > drivers/power/supply/Kconfig | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > > > > index faf2830aa1527..9f76e2f47ac6d 100644 > > > > --- a/drivers/power/supply/Kconfig > > > > +++ b/drivers/power/supply/Kconfig > > > > @@ -164,7 +164,7 @@ config BATTERY_DS2782 > > > > config BATTERY_LEGO_EV3 > > > > tristate "LEGO MINDSTORMS EV3 battery" > > > > - depends on OF && IIO && GPIOLIB > > > > + depends on OF && IIO && GPIOLIB && (ARCH_DAVINCI_DA850 || COMPILE_TEST) > > > > help > > > > Say Y here to enable support for the LEGO MINDSTORMS EV3 battery. > > > > > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options 2020-08-12 19:02 ` Alex Dewar @ 2020-08-12 19:12 ` David Lechner 2020-08-17 17:43 ` Alex Dewar 0 siblings, 1 reply; 9+ messages in thread From: David Lechner @ 2020-08-12 19:12 UTC (permalink / raw) To: Alex Dewar Cc: Sebastian Reichel, linux-pm, linux-kernel, Sekhar Nori, Bartosz Go??aszewski On 8/12/20 2:02 PM, Alex Dewar wrote: > On Wed, Aug 12, 2020 at 10:24:30AM -0500, David Lechner wrote: >> On 8/12/20 8:37 AM, Alex Dewar wrote: >>> On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote: >>>> On 8/9/20 1:54 PM, Alex Dewar wrote: >>>>> This battery appears only to be used by a single board (DA850), so it >>>>> makes sense to add this to the Kconfig file so that users don't build >>>>> the module unnecessarily. It currently seems to be built for the x86 >>>>> Arch Linux kernel where it's probably not doing much good. >>>> >>>> It would probably also make sense to add "default n" since it only >>>> applies to one board in the entire arch. >>> >>> Ah ok. That makes sense. Would you like me to send a follow-on patch for >>> this? >> >> You can just send a v2 patch that includes the change below and the >> additional change. > > I've just had a look at the documentation[1] and it seems that as there's > no "default y" there it'll default to n anyway. Have I got that right? > > [1] https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-attributes > Yes, that seems right. That makes me wonder why this would have been enabled in the Arch Linux kernel for x86 then. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options 2020-08-12 19:12 ` David Lechner @ 2020-08-17 17:43 ` Alex Dewar 2020-08-17 18:25 ` David Lechner 0 siblings, 1 reply; 9+ messages in thread From: Alex Dewar @ 2020-08-17 17:43 UTC (permalink / raw) To: David Lechner Cc: Alex Dewar, Sebastian Reichel, linux-pm, linux-kernel, Sekhar Nori, Bartosz Go??aszewski On Wed, Aug 12, 2020 at 02:12:57PM -0500, David Lechner wrote: > On 8/12/20 2:02 PM, Alex Dewar wrote: > > On Wed, Aug 12, 2020 at 10:24:30AM -0500, David Lechner wrote: > > > On 8/12/20 8:37 AM, Alex Dewar wrote: > > > > On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote: > > > > > On 8/9/20 1:54 PM, Alex Dewar wrote: > > > > > > This battery appears only to be used by a single board (DA850), so it > > > > > > makes sense to add this to the Kconfig file so that users don't build > > > > > > the module unnecessarily. It currently seems to be built for the x86 > > > > > > Arch Linux kernel where it's probably not doing much good. > > > > > > > > > > It would probably also make sense to add "default n" since it only > > > > > applies to one board in the entire arch. > > > > > > > > Ah ok. That makes sense. Would you like me to send a follow-on patch for > > > > this? > > > > > > You can just send a v2 patch that includes the change below and the > > > additional change. > > > > I've just had a look at the documentation[1] and it seems that as there's > > no "default y" there it'll default to n anyway. Have I got that right? > > > > [1] https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-attributes > > > > Yes, that seems right. That makes me wonder why this would have been enabled in > the Arch Linux kernel for x86 then. Not sure, maybe the Arch devs like Lego? ;-) Are you happy to give an Acked-by for this anyhoo? @Sebastian, are you happy to pick up this patch? Best, Alex ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options 2020-08-17 17:43 ` Alex Dewar @ 2020-08-17 18:25 ` David Lechner 2020-08-25 13:58 ` Sebastian Reichel 0 siblings, 1 reply; 9+ messages in thread From: David Lechner @ 2020-08-17 18:25 UTC (permalink / raw) To: Alex Dewar Cc: Sebastian Reichel, linux-pm, linux-kernel, Sekhar Nori, Bartosz Go??aszewski On 8/17/20 12:43 PM, Alex Dewar wrote: > On Wed, Aug 12, 2020 at 02:12:57PM -0500, David Lechner wrote: >> On 8/12/20 2:02 PM, Alex Dewar wrote: >>> On Wed, Aug 12, 2020 at 10:24:30AM -0500, David Lechner wrote: >>>> On 8/12/20 8:37 AM, Alex Dewar wrote: >>>>> On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote: >>>>>> On 8/9/20 1:54 PM, Alex Dewar wrote: >>>>>>> This battery appears only to be used by a single board (DA850), so it >>>>>>> makes sense to add this to the Kconfig file so that users don't build >>>>>>> the module unnecessarily. It currently seems to be built for the x86 >>>>>>> Arch Linux kernel where it's probably not doing much good. >>>>>> >>>>>> It would probably also make sense to add "default n" since it only >>>>>> applies to one board in the entire arch. >>>>> >>>>> Ah ok. That makes sense. Would you like me to send a follow-on patch for >>>>> this? >>>> >>>> You can just send a v2 patch that includes the change below and the >>>> additional change. >>> >>> I've just had a look at the documentation[1] and it seems that as there's >>> no "default y" there it'll default to n anyway. Have I got that right? >>> >>> [1] https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-attributes >>> >> >> Yes, that seems right. That makes me wonder why this would have been enabled in >> the Arch Linux kernel for x86 then. > > Not sure, maybe the Arch devs like Lego? ;-) > > Are you happy to give an Acked-by for this anyhoo? Yup. Acked-by: David Lechner <david@lechnology.com> > > @Sebastian, are you happy to pick up this patch? > > Best, > Alex > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options 2020-08-17 18:25 ` David Lechner @ 2020-08-25 13:58 ` Sebastian Reichel 0 siblings, 0 replies; 9+ messages in thread From: Sebastian Reichel @ 2020-08-25 13:58 UTC (permalink / raw) To: David Lechner Cc: Alex Dewar, linux-pm, linux-kernel, Sekhar Nori, Bartosz Go??aszewski [-- Attachment #1: Type: text/plain, Size: 148 bytes --] Hi, On Mon, Aug 17, 2020 at 01:25:45PM -0500, David Lechner wrote: > Acked-by: David Lechner <david@lechnology.com> Thanks, queued. -- Sebastian [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-08-25 13:59 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-08-09 18:54 [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options Alex Dewar 2020-08-11 14:24 ` David Lechner 2020-08-12 13:37 ` Alex Dewar 2020-08-12 15:24 ` David Lechner 2020-08-12 19:02 ` Alex Dewar 2020-08-12 19:12 ` David Lechner 2020-08-17 17:43 ` Alex Dewar 2020-08-17 18:25 ` David Lechner 2020-08-25 13:58 ` Sebastian Reichel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome