* [PATCH] clang-format: Fix: Maximum line length is now 100
@ 2020-08-18 16:24 Alex Dewar
2020-08-18 16:52 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Alex Dewar @ 2020-08-18 16:24 UTC (permalink / raw)
To: Miguel Ojeda, linux-kernel, clang-built-linux; +Cc: Alex Dewar
Since commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column
warning") the kernel style is now for lines to be a maximum of 100 rather
than 80 columns. Update .clang-format accordingly.
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
.clang-format | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.clang-format b/.clang-format
index a0a96088c74f..2b314a14a658 100644
--- a/.clang-format
+++ b/.clang-format
@@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
#BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
BreakAfterJavaFieldAnnotations: false
BreakStringLiterals: false
-ColumnLimit: 80
+ColumnLimit: 100
CommentPragmas: '^ IWYU pragma:'
#CompactNamespaces: false # Unknown to clang-format-4.0
ConstructorInitializerAllOnOneLineOrOnePerLine: false
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clang-format: Fix: Maximum line length is now 100
2020-08-18 16:24 [PATCH] clang-format: Fix: Maximum line length is now 100 Alex Dewar
@ 2020-08-18 16:52 ` Joe Perches
2020-08-18 16:53 ` Alex Dewar
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2020-08-18 16:52 UTC (permalink / raw)
To: Alex Dewar, Miguel Ojeda, linux-kernel, clang-built-linux
On Tue, 2020-08-18 at 17:24 +0100, Alex Dewar wrote:
> Since commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column
> warning") the kernel style is now for lines to be a maximum of 100 rather
> than 80 columns. Update .clang-format accordingly.
[]
> diff --git a/.clang-format b/.clang-format
[]
> @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
> #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
> BreakAfterJavaFieldAnnotations: false
> BreakStringLiterals: false
> -ColumnLimit: 80
> +ColumnLimit: 100
No thank you.
100 is used for exceptional line length, not
for reformatting all lines up to 100 chars.
See the previous discussion about the same patch
submitted earlier in June:
https://lore.kernel.org/lkml/20200610125147.2782142-1-christian.brauner@ubuntu.com/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clang-format: Fix: Maximum line length is now 100
2020-08-18 16:52 ` Joe Perches
@ 2020-08-18 16:53 ` Alex Dewar
0 siblings, 0 replies; 3+ messages in thread
From: Alex Dewar @ 2020-08-18 16:53 UTC (permalink / raw)
To: Joe Perches; +Cc: Alex Dewar, Miguel Ojeda, linux-kernel, clang-built-linux
On Tue, Aug 18, 2020 at 09:52:20AM -0700, Joe Perches wrote:
> On Tue, 2020-08-18 at 17:24 +0100, Alex Dewar wrote:
> > Since commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column
> > warning") the kernel style is now for lines to be a maximum of 100 rather
> > than 80 columns. Update .clang-format accordingly.
> []
> > diff --git a/.clang-format b/.clang-format
> []
> > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
> > #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
> > BreakAfterJavaFieldAnnotations: false
> > BreakStringLiterals: false
> > -ColumnLimit: 80
> > +ColumnLimit: 100
>
> No thank you.
>
> 100 is used for exceptional line length, not
> for reformatting all lines up to 100 chars.
>
> See the previous discussion about the same patch
> submitted earlier in June:
>
> https://lore.kernel.org/lkml/20200610125147.2782142-1-christian.brauner@ubuntu.com/
>
>
Ahh, my mistake. Thanks for getting back to me anyhoo.
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-18 16:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 16:24 [PATCH] clang-format: Fix: Maximum line length is now 100 Alex Dewar
2020-08-18 16:52 ` Joe Perches
2020-08-18 16:53 ` Alex Dewar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®