* [PATCH] net: cdc_ncm: Fix build error
@ 2020-08-26 6:52 YueHaibing
2020-08-26 7:03 ` Bjørn Mork
2020-08-26 14:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-08-26 6:52 UTC (permalink / raw)
To: davem, kuba, masahiroy, bjorn, miguel
Cc: linux-usb, netdev, linux-kernel, YueHaibing
If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails:
drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to `usbnet_cdc_update_filter'
Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e10dcb1b6ba7 ("net: cdc_ncm: hook into set_rx_mode to admit multicast traffic")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/usb/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index a7fbc3ccd29e..c7bcfca7d70b 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -252,6 +252,7 @@ config USB_NET_CDC_EEM
config USB_NET_CDC_NCM
tristate "CDC NCM support"
depends on USB_USBNET
+ select USB_NET_CDCETHER
default y
help
This driver provides support for CDC NCM (Network Control Model
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: cdc_ncm: Fix build error
2020-08-26 6:52 [PATCH] net: cdc_ncm: Fix build error YueHaibing
@ 2020-08-26 7:03 ` Bjørn Mork
2020-08-26 14:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Bjørn Mork @ 2020-08-26 7:03 UTC (permalink / raw)
To: YueHaibing
Cc: davem, kuba, masahiroy, miguel, linux-usb, netdev, linux-kernel
YueHaibing <yuehaibing@huawei.com> writes:
> If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails:
>
> drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to `usbnet_cdc_update_filter'
>
> Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this.
Ouch. For some reason I assumed that was always selected with usbnet.
Thanks for fixing.
Bjørn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: cdc_ncm: Fix build error
2020-08-26 6:52 [PATCH] net: cdc_ncm: Fix build error YueHaibing
2020-08-26 7:03 ` Bjørn Mork
@ 2020-08-26 14:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-08-26 14:29 UTC (permalink / raw)
To: yuehaibing
Cc: kuba, masahiroy, bjorn, miguel, linux-usb, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 26 Aug 2020 14:52:31 +0800
> If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails:
>
> drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to `usbnet_cdc_update_filter'
>
> Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e10dcb1b6ba7 ("net: cdc_ncm: hook into set_rx_mode to admit multicast traffic")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-26 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 6:52 [PATCH] net: cdc_ncm: Fix build error YueHaibing
2020-08-26 7:03 ` Bjørn Mork
2020-08-26 14:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®