* [PATCH] sched: idle: Change the cpu_idle_poll() return type to void
@ 2020-08-27 12:10 Frank Lee
0 siblings, 0 replies; 2+ messages in thread
From: Frank Lee @ 2020-08-27 12:10 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman
Cc: linux-kernel, tiny.windzz, Yangtao Li
From: Yangtao Li <frank@allwinnertech.com>
No one cares about the return value of this function, which only
increases the time spent in idle loop. Let's drop it.
Signed-off-by: Yangtao Li <frank@allwinnertech.com>
---
kernel/sched/idle.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index 6bf34986f45c..5250a7c466e6 100644
--- a/kernel/sched/idle.c
+++ b/kernel/sched/idle.c
@@ -52,7 +52,7 @@ static int __init cpu_idle_nopoll_setup(char *__unused)
__setup("hlt", cpu_idle_nopoll_setup);
#endif
-static noinline int __cpuidle cpu_idle_poll(void)
+static noinline void __cpuidle cpu_idle_poll(void)
{
rcu_idle_enter();
trace_cpu_idle_rcuidle(0, smp_processor_id());
@@ -65,8 +65,6 @@ static noinline int __cpuidle cpu_idle_poll(void)
start_critical_timings();
trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
rcu_idle_exit();
-
- return 1;
}
/* Weak implementations for optional arch specific functions */
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH] sched: idle: Change the cpu_idle_poll() return type to void
@ 2020-08-27 12:12 Frank Lee
0 siblings, 0 replies; 2+ messages in thread
From: Frank Lee @ 2020-08-27 12:12 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman
Cc: linux-kernel, tiny.windzz, Yangtao Li
From: Yangtao Li <frank@allwinnertech.com>
No one cares about the return value of this function, which only
increases the time spent in idle loop. Let's drop it.
Signed-off-by: Yangtao Li <frank@allwinnertech.com>
---
kernel/sched/idle.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index 6bf34986f45c..5250a7c466e6 100644
--- a/kernel/sched/idle.c
+++ b/kernel/sched/idle.c
@@ -52,7 +52,7 @@ static int __init cpu_idle_nopoll_setup(char *__unused)
__setup("hlt", cpu_idle_nopoll_setup);
#endif
-static noinline int __cpuidle cpu_idle_poll(void)
+static noinline void __cpuidle cpu_idle_poll(void)
{
rcu_idle_enter();
trace_cpu_idle_rcuidle(0, smp_processor_id());
@@ -65,8 +65,6 @@ static noinline int __cpuidle cpu_idle_poll(void)
start_critical_timings();
trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
rcu_idle_exit();
-
- return 1;
}
/* Weak implementations for optional arch specific functions */
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-27 12:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 12:10 [PATCH] sched: idle: Change the cpu_idle_poll() return type to void Frank Lee
2020-08-27 12:12 Frank Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®