* [PATCH v2] arm64: dts: zynqmp-zcu100-revC: correct interrupt flags
@ 2020-09-17 18:50 Krzysztof Kozlowski
2020-09-21 8:09 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-17 18:50 UTC (permalink / raw)
To: Rob Herring, Michal Simek, Rajan Vaja, Krzysztof Kozlowski,
Anurag Kumar Vulisha, devicetree, linux-arm-kernel, linux-kernel
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Not tested on HW.
Changes since v1:
1. Correct title
---
arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
index d60110ad8367..c9460693f4e9 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
@@ -186,7 +186,7 @@
compatible = "ti,tps65086";
reg = <0x5e>;
interrupt-parent = <&gpio>;
- interrupts = <77 GPIO_ACTIVE_LOW>;
+ interrupts = <77 IRQ_TYPE_LEVEL_LOW>;
#gpio-cells = <2>;
gpio-controller;
};
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: zynqmp-zcu100-revC: correct interrupt flags
2020-09-17 18:50 [PATCH v2] arm64: dts: zynqmp-zcu100-revC: correct interrupt flags Krzysztof Kozlowski
@ 2020-09-21 8:09 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2020-09-21 8:09 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Michal Simek, Rajan Vaja,
Anurag Kumar Vulisha, devicetree, linux-arm-kernel, linux-kernel
On 17. 09. 20 20:50, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted same
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Not tested on HW.
>
> Changes since v1:
> 1. Correct title
> ---
> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index d60110ad8367..c9460693f4e9 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -186,7 +186,7 @@
> compatible = "ti,tps65086";
> reg = <0x5e>;
> interrupt-parent = <&gpio>;
> - interrupts = <77 GPIO_ACTIVE_LOW>;
> + interrupts = <77 IRQ_TYPE_LEVEL_LOW>;
> #gpio-cells = <2>;
> gpio-controller;
> };
>
Applied to https://github.com/Xilinx/linux-xlnx/tree/zynqmp/dt.
M
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-21 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 18:50 [PATCH v2] arm64: dts: zynqmp-zcu100-revC: correct interrupt flags Krzysztof Kozlowski
2020-09-21 8:09 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®