* [PATCH v2] Staging: nvec: nvec: fix double next comment
@ 2020-09-27 16:35 Ryan Kosta
2020-09-27 16:45 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Ryan Kosta @ 2020-09-27 16:35 UTC (permalink / raw)
To: gregkh
Cc: marvin24, p.zabel, ac100, linux-tegra, devel, linux-kernel, Ryan Kosta
Changes since v1:
* Made commit message more clear
* Added description
Note: previous patch named
"[PATCH] fix double next comment in drivers/staging/nvec/nvec.c"
>8------------------------------------------------------8<
Fixes a comment typo.
Signed-off-by: Ryan Kosta <ryanpkosta@gmail.com>
---
drivers/staging/nvec/nvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec040774..a80996b2f5c 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -289,7 +289,7 @@ EXPORT_SYMBOL(nvec_write_async);
* interrupt handlers.
*
* Returns: 0 on success, a negative error code on failure.
- * The response message is returned in @msg. Shall be freed with
+ * The response message is returned in @msg. Shall be freed
* with nvec_msg_free() once no longer used.
*
*/
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Staging: nvec: nvec: fix double next comment
2020-09-27 16:35 [PATCH v2] Staging: nvec: nvec: fix double next comment Ryan Kosta
@ 2020-09-27 16:45 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-09-27 16:45 UTC (permalink / raw)
To: Ryan Kosta, gregkh
Cc: marvin24, p.zabel, ac100, linux-tegra, devel, linux-kernel
On Sun, 2020-09-27 at 09:35 -0700, Ryan Kosta wrote:
> Changes since v1:
> * Made commit message more clear
> * Added description
> Note: previous patch named
> "[PATCH] fix double next comment in drivers/staging/nvec/nvec.c"
> > 8------------------------------------------------------8<
> Fixes a comment typo.
Hi Ryan.
That comment should be _below_ the --- separator line
There's no need to double the nvec: word in the subject either.
And please use the imperative.
So the email message should look something like:
---------------------------------------------------------
From: <you>
Subject: [PATCH V2] staging: nvec: Remove repeated word typo in a comment
Fix a comment typo.
Signed-off-by: <you>
---
V2: Add a commit description
<patch>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-27 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-27 16:35 [PATCH v2] Staging: nvec: nvec: fix double next comment Ryan Kosta
2020-09-27 16:45 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®