* [PATCH] fs: ocfs2 remove unneeded break
@ 2020-10-19 17:52 trix
2020-10-20 1:20 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-19 17:52 UTC (permalink / raw)
To: mark, jlbec, joseph.qi, davem, akpm, willy, alex.shi
Cc: ocfs2-devel, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a goto
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/ocfs2/cluster/tcp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
index 79a231719460..3bd8119bed5e 100644
--- a/fs/ocfs2/cluster/tcp.c
+++ b/fs/ocfs2/cluster/tcp.c
@@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc,
msglog(hdr, "bad magic\n");
ret = -EINVAL;
goto out;
- break;
}
/* find a handler for it */
--
2.18.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: ocfs2 remove unneeded break
2020-10-19 17:52 [PATCH] fs: ocfs2 remove unneeded break trix
@ 2020-10-20 1:20 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2020-10-20 1:20 UTC (permalink / raw)
To: trix, mark, jlbec, davem, akpm, willy, alex.shi; +Cc: ocfs2-devel, linux-kernel
On 2020/10/20 01:52, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a goto
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/cluster/tcp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
> index 79a231719460..3bd8119bed5e 100644
> --- a/fs/ocfs2/cluster/tcp.c
> +++ b/fs/ocfs2/cluster/tcp.c
> @@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc,
> msglog(hdr, "bad magic\n");
> ret = -EINVAL;
> goto out;
> - break;
> }
>
> /* find a handler for it */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-20 1:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 17:52 [PATCH] fs: ocfs2 remove unneeded break trix
2020-10-20 1:20 ` Joseph Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome