* [PATCH] Drivers: ssb: remove unnecessary CONFIG_PM_SLEEP
@ 2020-10-29 7:54 Coiby Xu
2020-11-07 15:45 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Coiby Xu @ 2020-10-29 7:54 UTC (permalink / raw)
To: Michael Buesch; +Cc: open list:SONICS SILICON BACKPLANE DRIVER (SSB), open list
SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
drivers/ssb/pcihost_wrapper.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/ssb/pcihost_wrapper.c b/drivers/ssb/pcihost_wrapper.c
index 410215c16920..6510f57469a0 100644
--- a/drivers/ssb/pcihost_wrapper.c
+++ b/drivers/ssb/pcihost_wrapper.c
@@ -18,7 +18,6 @@
#include <linux/ssb/ssb.h>
-#ifdef CONFIG_PM_SLEEP
static int ssb_pcihost_suspend(struct device *d)
{
struct pci_dev *dev = to_pci_dev(d);
@@ -62,8 +61,6 @@ static const struct dev_pm_ops ssb_pcihost_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(ssb_pcihost_suspend, ssb_pcihost_resume)
};
-#endif /* CONFIG_PM_SLEEP */
-
static int ssb_pcihost_probe(struct pci_dev *dev,
const struct pci_device_id *id)
{
@@ -125,9 +122,7 @@ int ssb_pcihost_register(struct pci_driver *driver)
{
driver->probe = ssb_pcihost_probe;
driver->remove = ssb_pcihost_remove;
-#ifdef CONFIG_PM_SLEEP
driver->driver.pm = &ssb_pcihost_pm_ops;
-#endif
return pci_register_driver(driver);
}
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Drivers: ssb: remove unnecessary CONFIG_PM_SLEEP
2020-10-29 7:54 [PATCH] Drivers: ssb: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
@ 2020-11-07 15:45 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-11-07 15:45 UTC (permalink / raw)
To: Coiby Xu
Cc: Michael Buesch, open list:SONICS SILICON BACKPLANE DRIVER (SSB),
open list
Coiby Xu <coiby.xu@gmail.com> writes:
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
> drivers/ssb/pcihost_wrapper.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/ssb/pcihost_wrapper.c b/drivers/ssb/pcihost_wrapper.c
> index 410215c16920..6510f57469a0 100644
> --- a/drivers/ssb/pcihost_wrapper.c
> +++ b/drivers/ssb/pcihost_wrapper.c
> @@ -18,7 +18,6 @@
> #include <linux/ssb/ssb.h>
>
>
> -#ifdef CONFIG_PM_SLEEP
> static int ssb_pcihost_suspend(struct device *d)
> {
> struct pci_dev *dev = to_pci_dev(d);
> @@ -62,8 +61,6 @@ static const struct dev_pm_ops ssb_pcihost_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(ssb_pcihost_suspend, ssb_pcihost_resume)
> };
>
> -#endif /* CONFIG_PM_SLEEP */
> -
> static int ssb_pcihost_probe(struct pci_dev *dev,
> const struct pci_device_id *id)
> {
> @@ -125,9 +122,7 @@ int ssb_pcihost_register(struct pci_driver *driver)
> {
> driver->probe = ssb_pcihost_probe;
> driver->remove = ssb_pcihost_remove;
> -#ifdef CONFIG_PM_SLEEP
> driver->driver.pm = &ssb_pcihost_pm_ops;
> -#endif
>
> return pci_register_driver(driver);
> }
I'm not convinced that this is correct. How have you confirmed that
there are no compiler or sparse warnings?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-07 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 7:54 [PATCH] Drivers: ssb: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-11-07 15:45 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®