[PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA

[PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA

[Krzysztof Kozlowski]

The pl353-smc driver uses module_amba_driver so it has a build
dependency on CONFIG_ARM_AMBA:

    /usr/bin/arm-linux-gnueabi-ld: drivers/memory/pl353-smc.o: in function `pl353_smc_driver_init':
    pl353-smc.c:(.init.text+0x10): undefined reference to `amba_driver_register'

However it still can be compile tested on platforms other than ARM,
which in practice is limited to those selecting ARM_AMBA (so only
ARM64).

Reported-by: kernel test robot <lkp@intel.com>
Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/memory/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 00e013b14703..eebd2ddcd860 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -191,8 +191,8 @@ config DA8XX_DDRCTL
 config PL353_SMC
 	tristate "ARM PL35X Static Memory Controller(SMC) driver"
 	default y if ARM
-	depends on ARM
-	depends on ARM_AMBA || COMPILE_TEST
+	depends on ARM || COMPILE_TEST
+	depends on ARM_AMBA
 	help
 	  This driver is for the ARM PL351/PL353 Static Memory
 	  Controller(SMC) module.
-- 
2.25.1

Re: [PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA

[Nick Desaulniers]

+ authors/reviewers of commit fee10bd22678 ("memory: pl353: Add driver
for arm pl353 static memory controller")

On Thu, Oct 29, 2020 at 12:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The pl353-smc driver uses module_amba_driver so it has a build
> dependency on CONFIG_ARM_AMBA:
>
>     /usr/bin/arm-linux-gnueabi-ld: drivers/memory/pl353-smc.o: in function `pl353_smc_driver_init':
>     pl353-smc.c:(.init.text+0x10): undefined reference to `amba_driver_register'
>
> However it still can be compile tested on platforms other than ARM,
> which in practice is limited to those selecting ARM_AMBA (so only
> ARM64).
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/memory/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 00e013b14703..eebd2ddcd860 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -191,8 +191,8 @@ config DA8XX_DDRCTL
>  config PL353_SMC
>         tristate "ARM PL35X Static Memory Controller(SMC) driver"
>         default y if ARM
> -       depends on ARM
> -       depends on ARM_AMBA || COMPILE_TEST
> +       depends on ARM || COMPILE_TEST
> +       depends on ARM_AMBA
>         help
>           This driver is for the ARM PL351/PL353 Static Memory
>           Controller(SMC) module.
> --
> 2.25.1
>


-- 
Thanks,
~Nick Desaulniers

Re: [PATCH] memory: pl353-smc: fix compile test on !ARM_AMBA

[Michal Simek]

On 30. 10. 20 1:40, Nick Desaulniers wrote:
> + authors/reviewers of commit fee10bd22678 ("memory: pl353: Add driver
> for arm pl353 static memory controller")
> 
> On Thu, Oct 29, 2020 at 12:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> The pl353-smc driver uses module_amba_driver so it has a build
>> dependency on CONFIG_ARM_AMBA:
>>
>>     /usr/bin/arm-linux-gnueabi-ld: drivers/memory/pl353-smc.o: in function `pl353_smc_driver_init':
>>     pl353-smc.c:(.init.text+0x10): undefined reference to `amba_driver_register'
>>
>> However it still can be compile tested on platforms other than ARM,
>> which in practice is limited to those selecting ARM_AMBA (so only
>> ARM64).

Indeed.

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal