From: Sean V Kelley <sean.v.kelley@intel.com>
To: bhelgaas@google.com, Jonathan.Cameron@huawei.com,
xerces.zhao@gmail.com, rafael.j.wysocki@intel.com,
ashok.raj@intel.com, tony.luck@intel.com,
sathyanarayanan.kuppuswamy@intel.com, qiuxu.zhuo@intel.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Sean V Kelley <sean.v.kelley@intel.com>
Subject: [PATCH v10 00/16] Add RCEC handling to PCI/AER
Date: Thu, 5 Nov 2020 16:14:28 -0800 [thread overview]
Message-ID: <20201106001444.667232-1-sean.v.kelley@intel.com> (raw)
Changes since v9 [1], based on discussion [2], AER patch [3],
and pci/master tree [4]:
- No functional changes. Tested with aer injection.
PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR
- Tighten up aer_root_reset() as a preliminary patch separate from RCEC/RCIEP
series. So rebase series with the aer_root_reset() patch.
(Bjorn Helgaas)
[1] https://lore.kernel.org/linux-pci/20201016001113.2301761-1-seanvk.dev@oregontracks.org/
[2] https://lore.kernel.org/linux-pci/20201020162820.GA370938@bjorn-Precision-5520/
[3] https://lore.kernel.org/linux-pci/20201104232244.434115-1-sean.v.kelley@intel.com/
[4] https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/
Root Complex Event Collectors (RCEC) provide support for terminating error
and PME messages from Root Complex Integrated Endpoints (RCiEPs). An RCEC
resides on a Bus in the Root Complex. Multiple RCECs can in fact reside on
a single bus. An RCEC will explicitly declare supported RCiEPs through the
Root Complex Endpoint Association Extended Capability.
(See PCIe 5.0-1, sections 1.3.2.3 (RCiEP), and 7.9.10 (RCEC Ext. Cap.))
The kernel lacks handling for these RCECs and the error messages received
from their respective associated RCiEPs. More recently, a new CPU
interconnect, Compute eXpress Link (CXL) depends on RCEC capabilities for
purposes of error messaging from CXL 1.1 supported RCiEP devices.
DocLink: https://www.computeexpresslink.org/
This use case is not limited to CXL. Existing hardware today includes
support for RCECs, such as the Denverton microserver product
family. Future hardware will be forthcoming.
(See Intel Document, Order number: 33061-003US)
So services such as AER or PME could be associated with an RCEC driver.
In the case of CXL, if an RCiEP (i.e., CXL 1.1 device) is associated with a
platform's RCEC it shall signal PME and AER error conditions through that
RCEC.
Towards the above use cases, add the missing RCEC class and extend the
PCIe Root Port and service drivers to allow association of RCiEPs to their
respective parent RCEC and facilitate handling of terminating error and PME
messages.
Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> #non-native/no RCEC
Qiuxu Zhuo (4):
PCI/RCEC: Add RCEC class code and extended capability
PCI/RCEC: Bind RCEC devices to the Root Port driver
PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR
PCI/AER: Add RCEC AER error injection support
Sean V Kelley (12):
AER: aer_root_reset() non-native handling
PCI/RCEC: Cache RCEC capabilities in pci_init_capabilities()
PCI/ERR: Rename reset_link() to reset_subordinates()
PCI/ERR: Simplify by using pci_upstream_bridge()
PCI/ERR: Simplify by computing pci_pcie_type() once
PCI/ERR: Use "bridge" for clarity in pcie_do_recovery()
PCI/ERR: Avoid negated conditional for clarity
PCI/ERR: Add pci_walk_bridge() to pcie_do_recovery()
PCI/ERR: Limit AER resets in pcie_do_recovery()
PCI/RCEC: Add pcie_link_rcec() to associate RCiEPs
PCI/AER: Add pcie_walk_rcec() to RCEC AER handling
PCI/PME: Add pcie_walk_rcec() to RCEC PME handling
drivers/pci/pci.h | 29 ++++-
drivers/pci/pcie/Makefile | 2 +-
drivers/pci/pcie/aer.c | 79 +++++++++----
drivers/pci/pcie/aer_inject.c | 5 +-
drivers/pci/pcie/err.c | 93 +++++++++++-----
drivers/pci/pcie/pme.c | 15 ++-
drivers/pci/pcie/portdrv_core.c | 9 +-
drivers/pci/pcie/portdrv_pci.c | 8 +-
drivers/pci/pcie/rcec.c | 190 ++++++++++++++++++++++++++++++++
drivers/pci/probe.c | 2 +
include/linux/pci.h | 5 +
include/linux/pci_ids.h | 1 +
include/uapi/linux/pci_regs.h | 7 ++
13 files changed, 382 insertions(+), 63 deletions(-)
create mode 100644 drivers/pci/pcie/rcec.c
--
2.29.2
next reply other threads:[~2020-11-06 0:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 0:14 Sean V Kelley [this message]
2020-11-06 0:14 ` [PATCH v10 01/16] AER: aer_root_reset() non-native handling Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 02/16] PCI/RCEC: Add RCEC class code and extended capability Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 03/16] PCI/RCEC: Bind RCEC devices to the Root Port driver Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 04/16] PCI/RCEC: Cache RCEC capabilities in pci_init_capabilities() Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 05/16] PCI/ERR: Rename reset_link() to reset_subordinates() Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 06/16] PCI/ERR: Simplify by using pci_upstream_bridge() Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 07/16] PCI/ERR: Simplify by computing pci_pcie_type() once Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 08/16] PCI/ERR: Use "bridge" for clarity in pcie_do_recovery() Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 09/16] PCI/ERR: Avoid negated conditional for clarity Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 10/16] PCI/ERR: Add pci_walk_bridge() to pcie_do_recovery() Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 11/16] PCI/ERR: Limit AER resets in pcie_do_recovery() Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 12/16] PCI/RCEC: Add pcie_link_rcec() to associate RCiEPs Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 13/16] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR Sean V Kelley
2020-11-06 0:40 ` Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 14/16] PCI/AER: Add pcie_walk_rcec() to RCEC AER handling Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 15/16] PCI/PME: Add pcie_walk_rcec() to RCEC PME handling Sean V Kelley
2020-11-06 0:14 ` [PATCH v10 16/16] PCI/AER: Add RCEC AER error injection support Sean V Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106001444.667232-1-sean.v.kelley@intel.com \
--to=sean.v.kelley@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sathyanarayanan.kuppuswamy@intel.com \
--cc=tony.luck@intel.com \
--cc=xerces.zhao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®