From: Lee Jones <lee.jones@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Michael Brunner <Michael.Brunner@kontron.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"mibru@gmx.de" <mibru@gmx.de>,
"vkrasnov@dev.rtsoft.ru" <vkrasnov@dev.rtsoft.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mvanyulin@dev.rtsoft.ru" <mvanyulin@dev.rtsoft.ru>
Subject: Re: [PATCH v2] mfd: kempld-core: Check for DMI definition before ACPI
Date: Fri, 13 Nov 2020 10:14:38 +0000 [thread overview]
Message-ID: <20201113101438.GF3718728@dell> (raw)
In-Reply-To: <20201110161118.GE17288@roeck-us.net>
On Tue, 10 Nov 2020, Guenter Roeck wrote:
> On Tue, Nov 10, 2020 at 03:23:21PM +0000, Michael Brunner wrote:
> > Change the detection order to priorize DMI table entries over available
> > ACPI entries.
> >
> > This makes it more easy for product developers to patch product specific
> > handling into the driver.
> > Furthermore it allows to simplify the implementation a bit and
> > especially to remove the need to force synchronous probing.
> >
> > Based on the following commit introduced with v5.10-rc1:
> > commit e8299c7313af ("mfd: Add ACPI support to Kontron PLD driver")
> >
> > v2: Fixed coding style as suggested by Guenther Roeck
> >
>
> Nit: change logs should be after '---'.
Right. Please submit a v3 fixing this.
> Other than that,
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-11-13 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 7:46 [PATCH] " Michael Brunner
2020-11-10 14:39 ` Guenter Roeck
2020-11-10 15:41 ` Michael Brunner
2020-11-10 16:10 ` Guenter Roeck
2020-11-10 15:23 ` [PATCH v2] " Michael Brunner
2020-11-10 16:11 ` Guenter Roeck
2020-11-13 10:14 ` Lee Jones [this message]
2020-11-13 10:16 ` Lee Jones
2020-11-16 6:46 ` Michael Brunner
2020-11-16 6:42 ` [PATCH v3] " Michael Brunner
2020-11-27 7:53 ` Lee Jones
2020-11-30 13:08 ` Michael Brunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113101438.GF3718728@dell \
--to=lee.jones@linaro.org \
--cc=Michael.Brunner@kontron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mibru@gmx.de \
--cc=mvanyulin@dev.rtsoft.ru \
--cc=sameo@linux.intel.com \
--cc=vkrasnov@dev.rtsoft.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome