From: Punit Agrawal <punitagrawal@gmail.com>
To: rjw@rjwysocki.net
Cc: Punit Agrawal <punitagrawal@gmail.com>,
wei.huang2@amd.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, bp@alien8.de, x86@kernel.org
Subject: [RFC PATCH 2/4] cpufreq: acpi-cpufreq: Add processor to the ignore PSD override list
Date: Wed, 25 Nov 2020 23:48:45 +0900 [thread overview]
Message-ID: <20201125144847.3920-3-punitagrawal@gmail.com> (raw)
In-Reply-To: <20201125144847.3920-1-punitagrawal@gmail.com>
Booting Linux on a Zen2 based processor (family: 0x17, model: 0x60,
stepping: 0x1) shows the following message in the logs -
acpi_cpufreq: overriding BIOS provided _PSD data
Although commit 5368512abe08 ("acpi-cpufreq: Honor _PSD table setting
on new AMD CPUs") indicates that the override is not required for Zen3
onwards, it seems that domain information can be trusted even on
certain earlier systems. Update the check, to skip the override for
Zen2 processors known to work without the override.
Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
Cc: Wei Huang <wei.huang2@amd.com>
---
drivers/cpufreq/acpi-cpufreq.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index b1e7df96d428..29f1cd93541e 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -198,8 +198,13 @@ static int override_acpi_psd(unsigned int cpu_id)
if (c->x86_vendor == X86_VENDOR_AMD) {
if (!check_amd_hwpstate_cpu(cpu_id))
return false;
-
- return c->x86 < 0x19;
+ /*
+ * CPU's before Zen3 (except some Zen2) need the
+ * override.
+ */
+ return (c->x86 < 0x19) &&
+ !(c->x86 == 0x17 && c->x86_model == 0x60 &&
+ c->x86_stepping == 0x1);
}
return false;
--
2.29.2
next prev parent reply other threads:[~2020-11-25 14:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 14:48 [RFC PATCH 0/4] " Punit Agrawal
2020-11-25 14:48 ` [RFC PATCH 1/4] cpufreq: acpi-cpufreq: Re-factor overriding ACPI PSD Punit Agrawal
2020-12-07 19:29 ` Wei Huang
2020-12-08 23:31 ` Punit Agrawal
2020-11-25 14:48 ` Punit Agrawal [this message]
2020-12-07 20:20 ` [RFC PATCH 2/4] cpufreq: acpi-cpufreq: Add processor to the ignore PSD override list Wei Huang
2020-12-07 20:26 ` Borislav Petkov
2020-12-07 22:07 ` Wei Huang
2020-12-07 22:30 ` Borislav Petkov
2020-12-08 3:44 ` Wei Huang
2020-12-08 23:21 ` Punit Agrawal
2020-12-08 23:32 ` Borislav Petkov
2020-12-11 23:36 ` Punit Agrawal
2020-12-14 12:40 ` Borislav Petkov
2020-12-14 13:27 ` Punit Agrawal
2020-12-14 14:25 ` Borislav Petkov
2020-12-17 13:27 ` Punit Agrawal
2020-11-25 14:48 ` [RFC PATCH 3/4] x86/cpu: amd: Define processor families Punit Agrawal
2020-11-30 14:00 ` Borislav Petkov
2020-12-02 14:13 ` Punit Agrawal
2020-12-02 16:57 ` Borislav Petkov
2020-11-25 14:48 ` [RFC PATCH 4/4] cpufreq: acpi-cpufreq: Use identifiers for AMD processor family Punit Agrawal
2020-11-30 14:02 ` Borislav Petkov
2020-12-02 14:30 ` Punit Agrawal
2020-12-04 22:44 ` [RFC PATCH 0/4] Add processor to the ignore PSD override list Punit Agrawal
2020-12-07 13:55 ` Rafael J. Wysocki
2020-12-08 23:25 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125144847.3920-3-punitagrawal@gmail.com \
--to=punitagrawal@gmail.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wei.huang2@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome