From: Borislav Petkov <bp@alien8.de>
To: Punit Agrawal <punitagrawal@gmail.com>
Cc: rjw@rjwysocki.net, wei.huang2@amd.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [RFC PATCH 3/4] x86/cpu: amd: Define processor families
Date: Wed, 2 Dec 2020 17:57:56 +0100 [thread overview]
Message-ID: <20201202165756.GE2951@zn.tnic> (raw)
In-Reply-To: <87pn3s2t5d.fsf@stealth>
On Wed, Dec 02, 2020 at 11:13:02PM +0900, Punit Agrawal wrote:
> Didn't realize the core was internal only.
F10h is not internal only - all I'm saying is that "K10" wasn't use
inside AMD AFAIR.
> Makes sense - I will follow your suggestion in the next version.
Well, I don't think it is worth the churn, TBH.
I'd prefer comments over the f/m/s checks which explain what is matched
much better than defines for family numbers which are inadequate when
one needs to match the model too, for one.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-12-02 16:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 14:48 [RFC PATCH 0/4] Add processor to the ignore PSD override list Punit Agrawal
2020-11-25 14:48 ` [RFC PATCH 1/4] cpufreq: acpi-cpufreq: Re-factor overriding ACPI PSD Punit Agrawal
2020-12-07 19:29 ` Wei Huang
2020-12-08 23:31 ` Punit Agrawal
2020-11-25 14:48 ` [RFC PATCH 2/4] cpufreq: acpi-cpufreq: Add processor to the ignore PSD override list Punit Agrawal
2020-12-07 20:20 ` Wei Huang
2020-12-07 20:26 ` Borislav Petkov
2020-12-07 22:07 ` Wei Huang
2020-12-07 22:30 ` Borislav Petkov
2020-12-08 3:44 ` Wei Huang
2020-12-08 23:21 ` Punit Agrawal
2020-12-08 23:32 ` Borislav Petkov
2020-12-11 23:36 ` Punit Agrawal
2020-12-14 12:40 ` Borislav Petkov
2020-12-14 13:27 ` Punit Agrawal
2020-12-14 14:25 ` Borislav Petkov
2020-12-17 13:27 ` Punit Agrawal
2020-11-25 14:48 ` [RFC PATCH 3/4] x86/cpu: amd: Define processor families Punit Agrawal
2020-11-30 14:00 ` Borislav Petkov
2020-12-02 14:13 ` Punit Agrawal
2020-12-02 16:57 ` Borislav Petkov [this message]
2020-11-25 14:48 ` [RFC PATCH 4/4] cpufreq: acpi-cpufreq: Use identifiers for AMD processor family Punit Agrawal
2020-11-30 14:02 ` Borislav Petkov
2020-12-02 14:30 ` Punit Agrawal
2020-12-04 22:44 ` [RFC PATCH 0/4] Add processor to the ignore PSD override list Punit Agrawal
2020-12-07 13:55 ` Rafael J. Wysocki
2020-12-08 23:25 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202165756.GE2951@zn.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=punitagrawal@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=wei.huang2@amd.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®