* [PATCH] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning
@ 2021-01-15 7:40 Palmer Dabbelt
2021-09-14 4:15 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Palmer Dabbelt @ 2021-01-15 7:40 UTC (permalink / raw)
To: heiko
Cc: hjc, airlied, daniel, dri-devel, linux-arm-kernel,
linux-rockchip, linux-kernel, kernel-team, Palmer Dabbelt
From: Palmer Dabbelt <palmerdabbelt@google.com>
cdn_dp_resume is only used under PM_SLEEP, and now that it's static an
unused function warning is triggered undner !PM_SLEEP. This
conditionally enables the function to avoid the warning.
Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index a4a45daf93f2..063a60d213ba 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1121,6 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
return ret;
}
+#ifdef CONFIG_PM_SLEEP
static int cdn_dp_resume(struct device *dev)
{
struct cdn_dp_device *dp = dev_get_drvdata(dev);
@@ -1133,6 +1134,7 @@ static int cdn_dp_resume(struct device *dev)
return 0;
}
+#endif
static int cdn_dp_probe(struct platform_device *pdev)
{
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning
2021-01-15 7:40 [PATCH] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning Palmer Dabbelt
@ 2021-09-14 4:15 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2021-09-14 4:15 UTC (permalink / raw)
To: Palmer Dabbelt, heiko
Cc: hjc, airlied, daniel, dri-devel, linux-arm-kernel,
linux-rockchip, linux-kernel, kernel-team, Palmer Dabbelt
On 1/14/21 11:40 PM, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> cdn_dp_resume is only used under PM_SLEEP, and now that it's static an
> unused function warning is triggered undner !PM_SLEEP. This
> conditionally enables the function to avoid the warning.
>
> Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index a4a45daf93f2..063a60d213ba 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1121,6 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
> return ret;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> static int cdn_dp_resume(struct device *dev)
> {
> struct cdn_dp_device *dp = dev_get_drvdata(dev);
> @@ -1133,6 +1134,7 @@ static int cdn_dp_resume(struct device *dev)
>
> return 0;
> }
> +#endif
>
> static int cdn_dp_probe(struct platform_device *pdev)
> {
>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Is someone going to merge this patch from January?
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-14 4:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 7:40 [PATCH] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning Palmer Dabbelt
2021-09-14 4:15 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®