mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drivers: firmware: efi: fix Kconfig dependency on CRYPTO
@ 2021-02-27  3:29 Julian Braha
  2021-02-28 14:30 ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Julian Braha @ 2021-02-27  3:29 UTC (permalink / raw)
  To: ardb; +Cc: linux-efi, linux-kernel

When EFI_EMBEDDED_FIRMWARE is enabled, and CRYPTO is not enabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]

This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256
without selecting or depending on CRYPTO, despite CRYPTO_LIB_SHA256
depending on CRYPTO.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/firmware/efi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 2c3dac5ecb36..f914da9845ac 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -248,6 +248,7 @@ endmenu
 config EFI_EMBEDDED_FIRMWARE
 	bool
 	depends on EFI
+	select CRYPTO
 	select CRYPTO_LIB_SHA256
 
 config UEFI_CPER
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-28 21:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-27  3:29 [PATCH] drivers: firmware: efi: fix Kconfig dependency on CRYPTO Julian Braha
2021-02-28 14:30 ` Ard Biesheuvel
2021-02-28 21:32   ` Julian Braha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®