* [PATCH] staging: rtl8712: fixed whitespace coding style issue
@ 2021-03-09 12:49 Selvakumar Elangovan
0 siblings, 0 replies; 3+ messages in thread
From: Selvakumar Elangovan @ 2021-03-09 12:49 UTC (permalink / raw)
To: gregkh, Larry.Finger, florian.c.schilhabel
Cc: devel, linux-kernel, Selvakumar Elangovan
Removed additional whitspaces and added space around the binary operator in the rtl8712_xmit.h file
Signed-off-by: Selvakumar Elangovan <selvakumar16197@gmail.com>
---
drivers/staging/rtl8712/rtl8712_xmit.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_xmit.h b/drivers/staging/rtl8712/rtl8712_xmit.h
index 0b56bd3ac4d0..5cd651a0de75 100644
--- a/drivers/staging/rtl8712/rtl8712_xmit.h
+++ b/drivers/staging/rtl8712/rtl8712_xmit.h
@@ -36,10 +36,8 @@
#define MAX_AMSDU_XMITBUF_SZ 8704
#define MAX_TXAGG_XMITBUF_SZ 16384 /*16k*/
-
#define tx_cmd tx_desc
-
/*
*defined for TX DESC Operation
*/
@@ -89,10 +87,9 @@ struct tx_desc {
__le32 txdw7;
};
-
union txdesc {
struct tx_desc txdesc;
- unsigned int value[TXDESC_SIZE>>2];
+ unsigned int value[TXDESC_SIZE >> 2];
};
int r8712_xmitframe_complete(struct _adapter *padapter,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8712: fixed whitespace coding style issue
2021-03-09 12:54 Selvakumar Elangovan
@ 2021-03-09 13:25 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-03-09 13:25 UTC (permalink / raw)
To: Selvakumar Elangovan
Cc: Larry.Finger, florian.c.schilhabel, devel, linux-kernel
On Tue, Mar 09, 2021 at 06:24:45PM +0530, Selvakumar Elangovan wrote:
> Removed additional whitspaces and added space around the binary operator in the rtl8712_xmit.h file
Please wrap your changelog at 72 columns.
And you are doing 2 different things in this patch, please only do one
"logical" thing.
And finally, you sent 2 copies of this patch, I don't know which to
apply, so I'll drop both and wait for a v2.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: rtl8712: fixed whitespace coding style issue
@ 2021-03-09 12:54 Selvakumar Elangovan
2021-03-09 13:25 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Selvakumar Elangovan @ 2021-03-09 12:54 UTC (permalink / raw)
To: gregkh, Larry.Finger, florian.c.schilhabel; +Cc: devel, linux-kernel
Removed additional whitspaces and added space around the binary operator in the rtl8712_xmit.h file
Signed-off-by: Selvakumar Elangovan <selvakumar16197@gmail.com>
---
drivers/staging/rtl8712/rtl8712_xmit.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_xmit.h b/drivers/staging/rtl8712/rtl8712_xmit.h
index 0b56bd3ac4d0..5cd651a0de75 100644
--- a/drivers/staging/rtl8712/rtl8712_xmit.h
+++ b/drivers/staging/rtl8712/rtl8712_xmit.h
@@ -36,10 +36,8 @@
#define MAX_AMSDU_XMITBUF_SZ 8704
#define MAX_TXAGG_XMITBUF_SZ 16384 /*16k*/
-
#define tx_cmd tx_desc
-
/*
*defined for TX DESC Operation
*/
@@ -89,10 +87,9 @@ struct tx_desc {
__le32 txdw7;
};
-
union txdesc {
struct tx_desc txdesc;
- unsigned int value[TXDESC_SIZE>>2];
+ unsigned int value[TXDESC_SIZE >> 2];
};
int r8712_xmitframe_complete(struct _adapter *padapter,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-09 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09 12:49 [PATCH] staging: rtl8712: fixed whitespace coding style issue Selvakumar Elangovan
2021-03-09 12:54 Selvakumar Elangovan
2021-03-09 13:25 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®