From: Jan Kara <jack@suse.cz>
To: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Cc: jack@suse.cz, Horst Schirmeier <horst.schirmeier@tu-dortmund.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Updated locking documentation for journal_head
Date: Fri, 19 Mar 2021 11:37:01 +0100 [thread overview]
Message-ID: <20210319103701.GC4910@quack2.suse.cz> (raw)
In-Reply-To: <20210319091819.113326-1-alexander.lochmann@tu-dortmund.de>
On Fri 19-03-21 10:18:17, Alexander Lochmann wrote:
> LockDoc's results show that t_list_lock has been
> replaced by j_list_lock for b_next_transaction,
> b_tnext, and b_tprev.
> We, therefore, updated the documentation
> accordingly.
>
> Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
> Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
Yeah, I think that was a typo since the beginning. Thanks for the fix. Feel
free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/journal-head.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 75bc56109031..d68ae72784eb 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -80,13 +80,13 @@ struct journal_head {
> * Pointer to the running compound transaction which is currently
> * modifying the buffer's metadata, if there was already a transaction
> * committing it when the new transaction touched it.
> - * [t_list_lock] [b_state_lock]
> + * [j_list_lock] [b_state_lock]
> */
> transaction_t *b_next_transaction;
>
> /*
> * Doubly-linked list of buffers on a transaction's data, metadata or
> - * forget queue. [t_list_lock] [b_state_lock]
> + * forget queue. [j_list_lock] [b_state_lock]
> */
> struct journal_head *b_tnext, *b_tprev;
>
> --
> 2.20.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-03-19 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9864e9792b56bce87b016582a8759890079f7766>
2021-03-19 9:18 ` Alexander Lochmann
2021-03-19 10:37 ` Jan Kara [this message]
2021-03-19 10:47 ` [PATCH v2] " Alexander Lochmann
2021-06-05 13:07 ` Alexander Lochmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319103701.GC4910@quack2.suse.cz \
--to=jack@suse.cz \
--cc=alexander.lochmann@tu-dortmund.de \
--cc=horst.schirmeier@tu-dortmund.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®